Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] Added "collection_entry" block prefix to CollectionType entries#36088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

HeahDude
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#36039
LicenseMIT
Doc PRTODO

Allows to use globalcollection_entry_row,collection_entry_label,collection_entry_widget andcollection_entry_errors themes after dynamic_form_name_collection_name_entry_* ones.

Copy link
Member

@ycerutoyceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for taking care of this.

@HeahDudeHeahDudeforce-pushed thefeat/collection_entry-block_prefix branch 3 times, most recently from45feb67 to5fbc7caCompareMarch 15, 2020 22:02
@fabpot
Copy link
Member

@javiereguiluz Can you test this one and report?

@javiereguiluz
Copy link
Member

I've just tested this. I added the changes inCollectionType.php ... but it didn't work for me. I tried adding{% block collection_entry_row %} FOO {% endblock %} and{% block collection_entry_widget %} FOO {% endblock %} in my form theme ... but I don't see any difference. What could I be doing wrong? Thanks.

@HeahDude
Copy link
ContributorAuthor

Thanks for the feedback. That is weird I successfully tried with the Symfony demo app using thefields.html.twig yesterday. Are you sure there is not dynamic_field_name_* template with precedence?

Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I can confirm that this works as expected.

This morning@HeahDude helped me debug the problem ... I copy+pasted theCollectionType changes in the wrong file ... after copying them in the right file, everything is working perfectly!

@xabbuh
Copy link
Member

@HeahDude Can you make fabbot happy? :)

@xabbuhxabbuh added this to thenext milestoneMar 17, 2020
@HeahDudeHeahDudeforce-pushed thefeat/collection_entry-block_prefix branch from5fbc7ca to5e459b2CompareMarch 17, 2020 09:06
@HeahDudeHeahDudeforce-pushed thefeat/collection_entry-block_prefix branch from5e459b2 to2ff1f88CompareMarch 17, 2020 09:07
@HeahDude
Copy link
ContributorAuthor

@xabbuh done, I've also updated the changelog.

@xabbuh
Copy link
Member

Thank you Jules.

@xabbuhxabbuh merged commitc0ee02b intosymfony:masterMar 17, 2020
@HeahDudeHeahDude deleted the feat/collection_entry-block_prefix branchMarch 17, 2020 16:10
@nicolas-grekasnicolas-grekas modified the milestones:next,5.1May 4, 2020
@fabpotfabpot mentioned this pull requestMay 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@xabbuhxabbuhxabbuh approved these changes

@ycerutoycerutoyceruto approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

[Form] Allow to customize individual collection items in form themes
7 participants
@HeahDude@fabpot@javiereguiluz@xabbuh@yceruto@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp