Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Uid] use one class per type of UUID#36066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
029531a to5f6a725CompareUh oh!
There was an error while loading.Please reload this page.
96561be to8441fb0CompareUh oh!
There was an error while loading.Please reload this page.
#36064 has been merged now. |
fabpot approved these changesMar 14, 2020
thanks, rebased |
javiereguiluz approved these changesMar 14, 2020
lyrixx approved these changesMar 14, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
(embeds#36064 for now)
Would it make sense to have one class per type of UUID?
This aligns the type system and UUID types, so that one could type hint e.g.
UuidV4 $uuid.This PR does so.
UuidV1/2/3/4 andNullUuidall extend the baseUuidclass, which provides common methods and the factories needed to create each king of UUID.This means we don't need the
getType()nor theisNull()methods since they can be replaced by instanceof checks.As expected,
getTime()andgetMac()then now exist only on theUuidV1class - no need for any version check nor anyLogicExceptionanymore.Each type is guaranteed to contain a UUID that matches its class' type. The base
Uuidclass is used for the "no type" type.