Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Fallback to default answers when unable to read input#36031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
c24c696 to7248bb0Comparesrc/Symfony/Component/Console/Exception/MissingInputException.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
bendavies commentedMar 12, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
what about the fact that there is lots of code out there making decisions on |
7248bb0 to8ddaa20Compareostrolucky commentedMar 12, 2020
Valid point. Can you link some? |
teohhanhui commentedMar 12, 2020
Same argument I made in#36027 (comment) |
bendavies commentedMar 13, 2020
There are quite a few. I was just greping my vendor folder and there will obviously be third party instances of this too. |
ostrolucky commentedMar 13, 2020
Thanks for the list. I checked it and none of those commands should break:
|
fabpot commentedMar 16, 2020
Thank you@ostrolucky. |
danepowell commentedMar 19, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Just attaching a patch for folks wanting to test this via a composer patch to v4.4.5. (this patch removes conflicting test files that would otherwise be in the diff) |
ostrolucky commentedMar 19, 2020
No need, you may just suffix PR url with .patchhttps://github.com/symfony/symfony/pull/36031.patch |
danepowell commentedMar 19, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I tried that but it doesn't apply cleanly due to conflicting changes in the 4.4.x branch. My patch removes the conflicting test files. |
danepowell commentedMar 19, 2020
I've confirmed that this PR fixes the regression on my project, thanks. |
Uh oh!
There was an error while loading.Please reload this page.
Alternative to#36027.
This fixes linked issues without having to revert fix for#30726. Successfully tested with composer script,
docker runanddocker run -it.