Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Console] Fallback to default answers when unable to read input#36031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromostrolucky:fallback-from-stdin
Mar 16, 2020

Conversation

@ostrolucky
Copy link
Contributor

@ostroluckyostrolucky commentedMar 11, 2020
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#36027,Fix#35988
LicenseMIT
Doc PR

Alternative to#36027.

This fixes linked issues without having to revert fix for#30726. Successfully tested with composer script,docker run anddocker run -it.

@ostroluckyostroluckyforce-pushed thefallback-from-stdin branch 2 times, most recently fromc24c696 to7248bb0CompareMarch 11, 2020 18:55
@nicolas-grekasnicolas-grekas added this to the4.4 milestoneMar 12, 2020
@bendavies
Copy link
Contributor

bendavies commentedMar 12, 2020
edited
Loading

what about the fact that there is lots of code out there making decisions on$input->isInteractive() without using the question helper at all?
The behavior of all that code is different now.

teohhanhui reacted with thumbs up emoji

@ostrolucky
Copy link
ContributorAuthor

Valid point. Can you link some?

@teohhanhui
Copy link
Contributor

Same argument I made in#36027 (comment)

@bendavies
Copy link
Contributor

Valid point. Can you link some?

There are quite a few.
https://github.com/symfony/symfony/search?q=isInteractive&type=

I was just greping my vendor folder and there will obviously be third party instances of this too.

@ostrolucky
Copy link
ContributorAuthor

There are quite a few.
symfony/symfony/search?q=isInteractive&type=

Thanks for the list. I checked it and none of those commands should break:

  • password encoder: Interactive check is run only when not providing password via argument. Running command in non-interactive shell without providing password doesn't make sense in the first place, but even if you do, result is error, similarly as before.
  • debug:container: it uses question helper as fallback
  • messenger:failed:retry: Again fallback. It doesn't make sense to run this command in non-interactive shell without providing id
  • debug:form : it uses question helper as fallback

@fabpot
Copy link
Member

Thank you@ostrolucky.

@danepowell
Copy link
Contributor

danepowell commentedMar 19, 2020
edited
Loading

Just attaching a patch for folks wanting to test this via a composer patch to v4.4.5.
symfony-console-36031.txt

(this patch removes conflicting test files that would otherwise be in the diff)

@ostrolucky
Copy link
ContributorAuthor

No need, you may just suffix PR url with .patchhttps://github.com/symfony/symfony/pull/36031.patch

@danepowell
Copy link
Contributor

danepowell commentedMar 19, 2020
edited
Loading

I tried that but it doesn't apply cleanly due to conflicting changes in the 4.4.x branch. My patch removes the conflicting test files.

ostrolucky reacted with thumbs up emoji

@danepowell
Copy link
Contributor

I've confirmed that this PR fixes the regression on my project, thanks.

This was referencedMar 27, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

7 participants

@ostrolucky@bendavies@teohhanhui@fabpot@danepowell@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp