Just asking: why is the parameter string|string[] $needle instead of ...string $needles ?

I think it's to pass directly (without alteration) the method argument toindexOf.

instead of ...string $needles

Clearly, for consistency.

containsAny('string') is a step back compared tocontains('string') IMHO.

in this case doescontains(string $needle) + containsAny(array $needles) makes sense?

assuming we dont ever needcontainsAll(array $needles). But if so, it's still possible ... (containsAny('string') + containsAll('string') would be another step back)

alternatively, shouldnt we advice to compose any/all logic in userland based oncontains('string'), it's not likecontains('a') || contains('b') is that bad actually ;) (same forcontains('a') && contains('b')).

containsAny('string') is a step back compared to contains('string') IMHO.
in this case does contains(string $needle) + containsAny(array $needles) makes sense?

3 extra letters adding clarity win over a new method to me, especially considering that the class is already a collection of methods. We shouldn't inflate contains*() method in comparison to the other ones.

it's not like contains('a') || contains('b') is that bad actually

You should have a look again at the full interface of the class: several methods already supportstring|string[]. Not doing so for "contains" would be inconsistent.

Doing so is consistent, and useful.

Note that I'm fine naming this methodcontains() if that's the broader consensus. Please advise.

I think thatcontains() is ambiguous. I will look at it and always wonder ... is it"contains all" or"contains any" ? 🤔

this is the same problem we suffered for years with theis_granted(array $roles) method ... is it"all roles required" or"any role required" ?

there'sbefore/after() assuming OR already, is it less ambigious? is contains() specifically the confusing case ... thus worth a containsAny, but not before/afterAny? Is that inconsistent? if so, why dont we mind being inconsistent withcontains(string $needle) also then?

long term, are we really, really, sure about a defacto standard String component/API... without acontains method 🙉

do we really mind adding N*3 methods (single, any, all) IF the case is ambiguous, in favor of clear behavior + type info... is it worth this debate we have?

Apparently ppl don't have an issue with before/after. I suppose that's because nobody expects a "beforeAny" or "afterAny". That wouldn't mean anything useful and it intuitively is a beforeAll and afterAll.

the discussion proves that "contains" can be confusing.

I'm therefor confirming that I definitely also prefercontainsAny().

Thanks for raising the point.

Thank you@nicolas-grekas.