Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[LDAP] Add error code in exceptions generated by ldap#35913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sotty about fix style commits, my ide hack me continuosly |
nicolas-grekas approved these changesMar 2, 2020
Closes#33339 Thanks |
fabpot approved these changesMar 2, 2020
Thank you@vgpastor. |
fabpot added a commit that referenced this pull requestMar 2, 2020
…(Victor Garcia)This PR was squashed before being merged into the 5.1-dev branch.Discussion----------[LDAP] Add error code in exceptions generated by ldap| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? |no| Deprecations? | no| Tickets || License | MIT| Doc PR |This PR add the exception code returned by ldap PHP component to LdapException, and allow users a better way to detect the errors. Before this LdapException allways return code 0, and make neccesary evaluate the string returned to detect the error.Commits-------b4c90f0 [LDAP] Add error code in exceptions generated by ldap
dontub commentedMar 18, 2020
For the record: Commitdb46f3b doesn't fix some issues addressed in#33339.
|
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR add the exception code returned by ldap PHP component to LdapException, and allow users a better way to detect the errors. Before this LdapException allways return code 0, and make neccesary evaluate the string returned to detect the error.