Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[SecurityBundle] Minor fixes in configuration tree builder#35910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
HeahDude commentedFeb 29, 2020
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | ~ |
| License | MIT |
| Doc PR | ~ |
nicolas-grekas approved these changesMar 2, 2020
chalasr approved these changesMar 2, 2020
Member
chalasr commentedMar 2, 2020
Good catch, thanks@HeahDude. |
nicolas-grekas added a commit that referenced this pull requestMar 12, 2020
…ahDude)This PR was merged into the 4.4 branch.Discussion----------[SecurityBundle] Minor fix in LDAP config tree builder| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | ~| License | MIT| Doc PR | ~Continuation of#35910 for 4.4.Commits-------468a201 [SecurityBundle] Minor fix in LDAP config tree builder
This was referencedMar 27, 2020
Merged
Merged
Merged
nicolas-grekas added a commit that referenced this pull requestApr 18, 2020
…figurations (zek)This PR was merged into the 3.4 branch.Discussion----------[SecurityBundle] fix accepting env vars in remember-me configurations| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |Fix#36271| License | MIT| Doc PR | -As@wouterj explained we cannot use env variables after#35910 merged.> Hmm, so I'm guessing this is what happens:>> * `lifetime` is now an `integerNode()`> * For the Config component (which IIRC doesn't know anything about env variables), you're passing a string: `"%env(int:REMEMBER_ME_COOKIE_LIFETIME)%"`> * This throws an error, although if it wouldn't, the DI component would sucessfully process the string into a integer before it's used by any PHP class.>> So we either make Config aware of environment variables (that's probably a huge feature) or we revert the `integerNode()` changes (as you suggested).>>@HeahDude am I mislooking something, or would reverting these 2 lines not result in much harm? (only a little less strict config processor)Commits-------46c2783 [SecurityBundle] fix accepting env vars in remember-me configurations
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.