Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[SecurityBundle] Minor fixes in configuration tree builder#35910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
chalasr merged 1 commit intosymfony:3.4fromHeahDude:security-fix-xsd-34
Mar 2, 2020

Conversation

@HeahDude
Copy link
Contributor

QA
Branch?3.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets~
LicenseMIT
Doc PR~

@chalasr
Copy link
Member

Good catch, thanks@HeahDude.

@chalasrchalasr merged commitdcf3da8 intosymfony:3.4Mar 2, 2020
@HeahDudeHeahDude deleted the security-fix-xsd-34 branchMarch 2, 2020 12:37
nicolas-grekas added a commit that referenced this pull requestMar 12, 2020
…ahDude)This PR was merged into the 4.4 branch.Discussion----------[SecurityBundle] Minor fix in LDAP config tree builder| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | ~| License       | MIT| Doc PR        | ~Continuation of#35910 for 4.4.Commits-------468a201 [SecurityBundle] Minor fix in LDAP config tree builder
This was referencedMar 27, 2020
nicolas-grekas added a commit that referenced this pull requestApr 18, 2020
…figurations (zek)This PR was merged into the 3.4 branch.Discussion----------[SecurityBundle] fix accepting env vars in remember-me configurations| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#36271| License       | MIT| Doc PR        | -As@wouterj explained we cannot use env variables after#35910 merged.> Hmm, so I'm guessing this is what happens:>> * `lifetime` is now an `integerNode()`> * For the Config component (which IIRC doesn't know anything about env variables), you're passing a string: `"%env(int:REMEMBER_ME_COOKIE_LIFETIME)%"`> * This throws an error, although if it wouldn't, the DI component would sucessfully process the string into a integer before it's used by any PHP class.>> So we either make Config aware of environment variables (that's probably a huge feature) or we revert the `integerNode()` changes (as you suggested).>>@HeahDude am I mislooking something, or would reverting these 2 lines not result in much harm? (only a little less strict config processor)Commits-------46c2783 [SecurityBundle] fix accepting env vars in remember-me configurations
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@HeahDude@chalasr@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp