Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Config] Improve the deprecation features by handling package and version#35871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

atailouloute
Copy link
Contributor

@atailoulouteatailouloute commentedFeb 26, 2020•
edited by nicolas-grekas
Loading

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?yes
Ticketshttps://github.com/orgs/symfony/projects/1#card-32681032
LicenseMIT
Doc PRTODO

Copy link
Member

@stofstof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We still need to keep some tests (marked as@group legacy) covering the old API. Otherwise our BC layer is untested.

atailouloute reacted with thumbs up emoji
@atailoulouteatailoulouteforce-pushed theimprove-config-deprecation branch 9 times, most recently from97deb48 to6f80928CompareFebruary 26, 2020 16:52
@atailoulouteatailoulouteforce-pushed theimprove-config-deprecation branch 2 times, most recently from603caa7 to0c829a3CompareFebruary 26, 2020 19:10
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(with minor comments)

@atailoulouteatailoulouteforce-pushed theimprove-config-deprecation branch 2 times, most recently from99705c1 tobb1e5bcCompareFebruary 27, 2020 10:41
@nicolas-grekas
Copy link
Member

@atailouloute can you please take my comment into account and rebase meanwhile?

@atailoulouteatailoulouteforce-pushed theimprove-config-deprecation branch fromc8ddd80 tobc42f71CompareMarch 31, 2020 20:57
@atailouloute
Copy link
ContributorAuthor

@nicolas-grekas Done
Some tests are broken (I don't know why), but they are not related to this issue.

@nicolas-grekasnicolas-grekasforce-pushed theimprove-config-deprecation branch frombc42f71 tof4de76dCompareApril 1, 2020 08:41
@nicolas-grekas
Copy link
Member

Thank you@atailouloute.

* You can use %node% and %path% placeholders in your message to display,
* respectively, the node name and its complete path.
*/
public function setDeprecated(?string $message)
public function setDeprecated(?string $package/*, string $version, string $message = 'The child node "%node%" at path "%path%" is deprecated.' */)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Adding the parameters at the front makes it impossible to both support 5.1+ and <5.1 as a bundle.

If you use the intended 5.1+ way:
->setDeprecated("my/bundle", "1.0", "this node is deprecated, do sth else")

  • in5.1+ we will show the message"this node is deprecated, do sth else"
  • in<5.1 we will show the message"my/bundle"

Is there a (non-hacky) way to have the real message in both versions?

@nicolas-grekas@atailouloute

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I just created#37284 to track this

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@apfelboxapfelboxapfelbox left review comments

@maxheliasmaxheliasmaxhelias approved these changes

@stofstofAwaiting requested review from stof

Assignees
No one assigned
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

6 participants
@atailouloute@nicolas-grekas@stof@apfelbox@maxhelias@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp