Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] Add unit tests#35847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.0fromjschaedl:notifier-tests-channel
Mar 16, 2020
Merged

Conversation

@jschaedl
Copy link
Contributor

@jschaedljschaedl commentedFeb 24, 2020•
edited
Loading

QA
Branch?5.0
Bug fix?no
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

GromNaN reacted with thumbs up emoji
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks for starting this
I suppose these don't apply on 5.0? if they do, the PR should target 5.0.

jschaedl reacted with thumbs up emoji
@jschaedljschaedl marked this pull request as ready for reviewFebruary 28, 2020 20:39
@jschaedl
Copy link
ContributorAuthor

@nicolas-grekas

I suppose these don't apply on 5.0? if they do, the PR should target 5.0.

I would like to add tests for theEmailChannel,SmsChannel andChatChannel here as well, but wanted to wait for#35773 first.

If you are fine with only mergingAbstractChannelTest andChannelPolicyTest we could indeed target 5.0 for now. Then I could do the tests forEmailChannel,SmsChannel andChatChannel later or in#35773.

What do you think?

@nicolas-grekas
Copy link
Member

Yes please: tests that run on 5.0 should be submitted there. Then tests for new notifiers should go on master.

jschaedl reacted with thumbs up emoji

@jschaedljschaedlforce-pushed thenotifier-tests-channel branch 2 times, most recently from3444d60 toaf0d162CompareMarch 2, 2020 18:51
@jschaedljschaedl changed the base branch frommaster to5.0March 2, 2020 18:51
@jschaedljschaedlforce-pushed thenotifier-tests-channel branch fromaf0d162 to022c170CompareMarch 8, 2020 09:16
@nicolas-grekasnicolas-grekas added this to the5.0 milestoneMar 12, 2020
@nicolas-grekas
Copy link
Member

(failures unrelated, needs review)

@fabpot
Copy link
Member

Thank you@jschaedl.

jschaedl reacted with hooray emoji

@fabpotfabpot merged commit16ed2b9 intosymfony:5.0Mar 16, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

Assignees

No one assigned

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jschaedl@nicolas-grekas@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp