Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Notifier] Dispatch message event in null transport#35841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@jschaedl
Copy link
Contributor

QA
Branch?5.0
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

I think we should be able to log notifications via theNotificationLoggerListener even if they were sent to a null transport. The mailer component does it the same way.

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The mailer component does it the same way.

I confirm.


publicfunction__construct(EventDispatcherInterface$dispatcher =null)
{
$this->dispatcher = LegacyEventDispatcherProxy::decorate($dispatcher);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

$this->dispatcher = class_exists(\Symfony\Component\EventDispatcher\Event::class) ? LegacyEventDispatcherProxy::decorate($dispatcher) : $dispatcher;

jschaedl reacted with thumbs up emoji
@fabpotfabpotforce-pushed thenotifier-null-transport-dispatcher branch from2786993 toa0d99ceCompareFebruary 24, 2020 17:03
@fabpot
Copy link
Member

Thank you@jschaedl.

jschaedl reacted with hooray emoji

@fabpotfabpot merged commit8b819ba intosymfony:5.0Feb 24, 2020
@fabpotfabpot mentioned this pull requestFeb 29, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

Assignees

No one assigned

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jschaedl@fabpot@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp