Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Debug][ErrorHandler] improved deprecation notices for methods new args and return type#35832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@HeahDude
Copy link
Contributor

@HeahDudeHeahDude commentedFeb 23, 2020•
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets~
LicenseMIT
Doc PR~

I don't know if this should be considered a bug fix or a feature.

@HeahDudeHeahDudeforce-pushed thedebug_class-tweak-dreprecation_notice branch from1f25db4 to548eb36CompareFebruary 23, 2020 12:20
@HeahDudeHeahDude changed the title[Error handler] improved deprecation notices for methods new args and return type[ErrorHandler] improved deprecation notices for methods new args and return typeFeb 23, 2020
Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fine for 4.4 I'd say

HeahDude and yceruto reacted with thumbs up emoji
@HeahDudeHeahDude changed the base branch frommaster to4.4February 23, 2020 13:51
@HeahDudeHeahDudeforce-pushed thedebug_class-tweak-dreprecation_notice branch from548eb36 toc6d9f30CompareFebruary 23, 2020 13:53
@HeahDude
Copy link
ContributorAuthor

I've changed the target.

@HeahDudeHeahDudeforce-pushed thedebug_class-tweak-dreprecation_notice branch fromc6d9f30 toe3b1926CompareFebruary 23, 2020 14:08
@HeahDudeHeahDude changed the title[ErrorHandler] improved deprecation notices for methods new args and return type[Debug][ErrorHandler] improved deprecation notices for methods new args and return typeFeb 23, 2020
@HeahDude
Copy link
ContributorAuthor

I've fixed the tests in theDebug component too though.

@HeahDudeHeahDudeforce-pushed thedebug_class-tweak-dreprecation_notice branch from4a22ad8 to875d479CompareFebruary 23, 2020 14:30
@HeahDudeHeahDudeforce-pushed thedebug_class-tweak-dreprecation_notice branch from875d479 to83d4aa7CompareFebruary 23, 2020 14:41
@chalasrchalasr added this to the4.4 milestoneFeb 23, 2020
@nicolas-grekas
Copy link
Member

Thank you@HeahDude.

@nicolas-grekasnicolas-grekas merged commitda28445 intosymfony:4.4Feb 24, 2020
@HeahDudeHeahDude deleted the debug_class-tweak-dreprecation_notice branchFebruary 24, 2020 15:47
This was referencedFeb 29, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@ycerutoycerutoyceruto approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@HeahDude@nicolas-grekas@yceruto@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp