Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[BrowserKit] Nested file array prevents uploading file#35827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
afilina commentedFeb 22, 2020
I don't understand what's wrong with thew CI system. Appveyor reports an error despite having all checks green. fabpot.io reports CS issues. I went and fixed CS issues inpreexisting code as per the CONTRIBUTING.md docs, and now fabpot.io reports reports one more issue than previously. I have no idea what I'm expected to do here to pass the build. The rules are obfuscated and this bug is going to affect my workshop on Monday. |
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you@afilina.
I rebased your PR to target 4.4 + fixed some minor CS issues meanwhile.
nicolas-grekas commentedFeb 23, 2020
Thank you@afilina. |
… uploads (codebay)This PR was squashed before being merged into the 4.4 branch.Discussion----------[BrowserKit] fixed missing post request parameters in file uploads| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| License | MITPull Request#35827 "[BrowserKit] Nested file array prevents uploading file" introduced a bug that had not been previously covered by unit tests for the component. Requests that include additional parameters with a file upload are not being includedCommits-------7abee62 [BrowserKit] fixed missing post request parameters in file uploads
Uh oh!
There was an error while loading.Please reload this page.
The HttpBrowser doesn't play nicely with Symfony\Component\DomCrawler::getPhpFiles().
The former assumes a flat array structure, while the latter explicitly un-flattens it, causing files to silently get ignored by the DomCrawler's submitForm.