Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Mailer][DX] Add notice log when email recipients are not defined#35818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| } | ||
| if (!$envelope->getRecipients()) { | ||
| $this->getLogger()->notice('There are no recipients in the mailer envelope. Nothing was sent.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would have expected aLogicException and a hint about what I can do to fix the problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@jschaedl i did not know the logic behind the « ?SentMessage » method return signature
that is why i added a log and not thrown ex and remove the return null
Maybe we need to wait other review comment :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fabpot commentedApr 16, 2020
I've fixed the root issue(s) in#36467 |
This PR was merged into the 4.4 branch.Discussion----------Mailer from sender fixes| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets |Fix#35818,Fix#35805,Fix#33753 | License | MIT| Doc PR | n/aCommits-------e885860 Fix From/Sender handling in Emails
Hi,
Add a log in order to be aware that no email was sent due to bad data
IF the PR is accepted, is the log level
noticethe right one?thx