Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[3.4][DoctrineBridge] Use new Types::* constants and support new json type#35817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@fancyweb
Copy link
Contributor

QA
Branch?3.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

AllType::* constants were moved and deprecated. This PR makes sure we use the good ones when they exist so we are prepared for their removal. It allows to be deprecation free. If deprecated constants could be detected, we would have failing tests 😄

Also,json_array was deprecated and renamed tojson, so I added support for this new type.

Some new components also use these constants on upper branches, so I will submit PRs there.

@fancyweb
Copy link
ContributorAuthor

I think fabbot failures should be ignored based on the existant code.

@fancywebfancywebforce-pushed thedoctrine-bridge-types-constants branch from55baa60 toeb6e219CompareFebruary 21, 2020 16:54
@ogizanagiogizanagi added this to the3.4 milestoneFeb 21, 2020
@fancywebfancywebforce-pushed thedoctrine-bridge-types-constants branch from04649fd to3e35fa5CompareFebruary 24, 2020 13:11
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(false positive from fabbot)

@nicolas-grekas
Copy link
Member

Thank you@fancyweb.

@nicolas-grekasnicolas-grekas merged commit9819814 intosymfony:3.4Feb 24, 2020
@fancywebfancyweb deleted the doctrine-bridge-types-constants branchFebruary 24, 2020 14:05
@nicolas-grekas
Copy link
Member

I failed to merge this in 4.4, please submit for 4.4 in#35819 or in a separate PR :)

fabpot added a commit that referenced this pull requestFeb 25, 2020
…rt new json types (fancyweb)This PR was merged into the 4.4 branch.Discussion----------[4.4][DoctrineBridge] Use new Types::* constants and support new json types| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |#35817 (comment)| License       | MIT| Doc PR        | -Commits-------ddf3353 [4.4][DoctrineBridge] Use new Types::* constants and support new json type
This was referencedFeb 29, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

+1 more reviewer

@TaluuTaluuTaluu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

5 participants

@fancyweb@nicolas-grekas@Taluu@ogizanagi@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp