Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpFoundation] Add support for all core response http control directives#35748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromazjezz:cache-headers
Apr 5, 2020

Conversation

azjezz
Copy link
Contributor

@azjezzazjezz commentedFeb 17, 2020•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#35720
LicenseMIT
Doc PRN/A

Add support for all core cache-control directives

see :https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control

@azjezzazjezz changed the title[HttpFoundation] Add support for all core http control directives[HttpFoundation] Add support for all core response http control directivesFeb 17, 2020
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add tests.

@nicolas-grekasnicolas-grekas added this to thenext milestoneFeb 18, 2020
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe some tests, a changelog entry?

azjezz reacted with thumbs up emoji
@azjezz
Copy link
ContributorAuthor

Added tests and a changelog entry.

@nicolas-grekas
Copy link
Member

@azjezz thanks. What about#35748 (comment) ?

@fabpot
Copy link
Member

Thank you@azjezz.

@fabpotfabpot merged commit402909f intosymfony:masterApr 5, 2020
@driesvintsdriesvints mentioned this pull requestApr 7, 2020
fabpot added a commit that referenced this pull requestApr 8, 2020
This PR was squashed before being merged into the 5.1-dev branch.Discussion----------Fix constant accessor| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       | Fix #... <!-- prefix each issue number with "Fix #", if any -->| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->Because HTTP_RESPONSE_CACHE_CONTROL_DIRECTIVES is private, using static will fail for any classes extending the Response class. HTTP_RESPONSE_CACHE_CONTROL_DIRECTIVES is already properly using self a bit lower so we should do the same thing here.Introduced in#35748Commits-------633ff5b Fix constant accessor
@nicolas-grekasnicolas-grekas modified the milestones:next,5.1May 4, 2020
@fabpotfabpot mentioned this pull requestMay 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

add support for appending no-cache to Cache-Control header
5 participants
@azjezz@nicolas-grekas@fabpot@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp