Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] Added a "choice_filter" option to ChoiceType#35733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@HeahDude
Copy link
Contributor

@HeahDudeHeahDude commentedFeb 15, 2020•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?yes
TicketsFix#32657
LicenseMIT
Doc PRsymfony/symfony-docs#13223

Finally opening this PR for a very old branch, based on both#34550 (merged) and#30994 (merged).

Until#30994 is merged, this PR should better be reviewed by commits. Thanks!

ro0NL, fancyweb, apfelbox, atailouloute, yceruto, ogizanagi, and bigfoot90 reacted with hooray emoji
@HeahDudeHeahDudeforce-pushed thefeature-choice_type-choice_filter-option branch 9 times, most recently from5c927c9 todf56a76CompareFebruary 16, 2020 15:00
@nicolas-grekasnicolas-grekas added this to thenext milestoneFeb 18, 2020
@HeahDudeHeahDudeforce-pushed thefeature-choice_type-choice_filter-option branch 5 times, most recently from3812a56 to93dac3eCompareFebruary 22, 2020 12:58
@HeahDude
Copy link
ContributorAuthor

Rebased on master, added some more tests and the documentation PR. Ready from my side.

@HeahDudeHeahDudeforce-pushed thefeature-choice_type-choice_filter-option branch 3 times, most recently fromc296699 to6feee70CompareFebruary 22, 2020 18:06
@HeahDudeHeahDudeforce-pushed thefeature-choice_type-choice_filter-option branch 2 times, most recently frome86ba3d to37ffbc4CompareFebruary 23, 2020 10:33
@HeahDudeHeahDudeforce-pushed thefeature-choice_type-choice_filter-option branch 3 times, most recently from002af90 to2c172caCompareFebruary 23, 2020 13:02
@HeahDude
Copy link
ContributorAuthor

Thanks for the review, addressed everything. Added even more tests and fixed one from#30994 with some missing annotations as well.

@HeahDude
Copy link
ContributorAuthor

HeahDude commentedFeb 23, 2020•
edited
Loading

I've added a new commita54f389 which has two benefits:

  • reduce the complexity in the default factory by encapsulating the logic in the loader decorator (helped me spotting a bug already covered by tests)
  • lazy filtering, it means that when submitting empty data on optional field the choices won't be loaded or when some data is submitted and valid they will be partially filtered

@HeahDudeHeahDudeforce-pushed thefeature-choice_type-choice_filter-option branch 2 times, most recently from8db187f toa54f389CompareFebruary 23, 2020 19:37
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(with minor comments)

@HeahDudeHeahDudeforce-pushed thefeature-choice_type-choice_filter-option branch 2 times, most recently from6e515e5 tof487c6cCompareFebruary 24, 2020 22:29
@HeahDudeHeahDudeforce-pushed thefeature-choice_type-choice_filter-option branch 2 times, most recently from2a76f52 tofbc06f0CompareFebruary 25, 2020 21:16
@HeahDudeHeahDudeforce-pushed thefeature-choice_type-choice_filter-option branch fromfbc06f0 to72c2a26CompareFebruary 27, 2020 07:31
Copy link
Contributor

@ogizanagiogizanagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you so much for working back on this long-time requested feature

@HeahDudeHeahDudeforce-pushed thefeature-choice_type-choice_filter-option branch 2 times, most recently from64f6fcc to19dc45bCompareMarch 15, 2020 10:31
@HeahDudeHeahDudeforce-pushed thefeature-choice_type-choice_filter-option branch from19dc45b toed2c312CompareMarch 15, 2020 15:49
@fabpot
Copy link
Member

Thank you@HeahDude.

HeahDude reacted with hooray emoji

@fabpotfabpot merged commite0bddee intosymfony:masterMar 16, 2020
@HeahDudeHeahDude deleted the feature-choice_type-choice_filter-option branchMarch 16, 2020 06:48
HeahDude added a commit to symfony/symfony-docs that referenced this pull requestApr 12, 2020
This PR was merged into the master branch.Discussion----------[Form] added the "choice_filter" optionDocumentation forsymfony/symfony#35733.Based on#13182 for now, so better be reviewed by commit here until it's merged and rebased, thanks!Commits-------8b0c09e [Form] added the "choice_filter" option
@nicolas-grekasnicolas-grekas modified the milestones:next,5.1May 4, 2020
@fabpotfabpot mentioned this pull requestMay 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@fabpotfabpotfabpot approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuh

+1 more reviewer

@ogizanagiogizanagiogizanagi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

Option to filter choices

5 participants

@HeahDude@fabpot@nicolas-grekas@ogizanagi@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp