Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Routing] marked configurators traits as internal#35731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

HeahDude
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?no
Deprecations?no
TicketsFix#30501 (comment)
LicenseMIT
Doc PRnot needed

@nicolas-grekas
Copy link
Member

Only traits new to 5.1 should be made internal.

@HeahDude
Copy link
ContributorAuthor

Alright, fixed.

@nicolas-grekas
Copy link
Member

Thank you@HeahDude.

nicolas-grekas added a commit that referenced this pull requestFeb 15, 2020
…ude)This PR was merged into the 5.1-dev branch.Discussion----------[Routing] marked configurators traits as internal| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       |Fix#30501 (comment) <!-- prefix each issue number with "Fix #", if any -->| License       | MIT| Doc PR        | not needed<!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/releases): - Always add tests and ensure they pass. - Never break backward compatibility (seehttps://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch master.-->Commits-------52efec7 [Routing] marked configurators traits as internal
@nicolas-grekasnicolas-grekas merged commit52efec7 intosymfony:masterFeb 15, 2020
@HeahDudeHeahDude deleted the internal-routing-traits branchFebruary 15, 2020 10:46
@nicolas-grekasnicolas-grekas modified the milestones:next,5.1May 4, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

3 participants
@HeahDude@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp