Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] Correctly round model with PercentType and add a rounding_mode option#35729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

VincentLanglet
Copy link
Contributor

@VincentLangletVincentLanglet commentedFeb 14, 2020•
edited
Loading

QA
Branch?master
Bug fix?yes
New feature?yes
Deprecations?no
TicketsFix#35296
LicenseMIT
Doc PRsymfony/symfony-docs#13138

@VincentLangletVincentLangletforce-pushed theroundPercentTypeValue branch 2 times, most recently from24eb4c3 to8b3de3cCompareFebruary 14, 2020 23:17
@VincentLangletVincentLanglet marked this pull request as ready for reviewFebruary 14, 2020 23:32
@nicolas-grekasnicolas-grekas changed the titleCorrectly round model with PercentType and add a rounding_mode option[Form] Correctly round model with PercentType and add a rounding_mode optionFeb 15, 2020
@nicolas-grekasnicolas-grekas added this to thenext milestoneFeb 15, 2020
@VincentLanglet
Copy link
ContributorAuthor

@nicolas-grekas I made the PR on master because I added an optionrounding_mode.

But I kinda consider as a bug the fact the value is not rounded in3.4,4.4 and5.0 versions. Should I make a bugfix PR on theses versions with only the round function but norounding_mode parameter ?

@VincentLanglet
Copy link
ContributorAuthor

If the PR#35781 is accepted, I'll need to include the same fix.

@VincentLanglet
Copy link
ContributorAuthor

@nicolas-grekas@xabbuh Hi ! Is something missing with this PR ? :)

@fabpotfabpotforce-pushed theroundPercentTypeValue branch frome564a8d tod97565dCompareMarch 16, 2020 06:22
@fabpot
Copy link
Member

Thank you@VincentLanglet.

@fabpotfabpot merged commit06a1a1b intosymfony:masterMar 16, 2020
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestMar 16, 2020
This PR was merged into the master branch.Discussion----------Add doc for rounding_modeRelated tosymfony/symfony#35729Commits-------fcc8641 Add doc for rounding_mode
@nicolas-grekasnicolas-grekas modified the milestones:next,5.1May 4, 2020
@fabpotfabpot mentioned this pull requestMay 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@xabbuhxabbuhAwaiting requested review from xabbuh

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

Assignees
No one assigned
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

Form "PercentType" parameter "scale" inconsistency with "NumberType"
5 participants
@VincentLanglet@fabpot@nicolas-grekas@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp