Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add missing autoload calls#35728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromgreg0ire:add-missing-autoload-calls
Feb 15, 2020

Conversation

@greg0ire
Copy link
Contributor

@greg0iregreg0ire commentedFeb 14, 2020
edited
Loading

Until either php 7.4 or doctrine/persistence 2 is required, these will
be needed to make sure php recognises signatures using the old names as
compatible with signatures using the new names.
This is necessary for types defined outside Symfony that extend types
from Symfony and still use the old names in signatures of methods they
override.

Fixesdoctrine/DoctrineMongoDBBundle#616

QA
Branch?4.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsFixdoctrine/DoctrineMongoDBBundle#616
LicenseMIT
Doc PRn/a

This topic is fairly complicated, more details athttps://dev.to/greg0ire/how-to-deprecate-a-type-in-php-48cf

@nicolas-grekas
Copy link
Member

4.3 is EOLed.
4.4 or 3.4 now.

greg0ire reacted with thumbs up emoji

Until either php 7.4 or doctrine/persistence 2 is required, these willbe needed to make sure php recognises signatures using the old names ascompatible with signatures using the new names.This is necessary for types defined outside Symfony that extend typesfrom Symfony and still use the old names in signatures of methods theyoverride.More details athttps://dev.to/greg0ire/how-to-deprecate-a-type-in-php-48cfFixesdoctrine/DoctrineMongoDBBundle#616
@greg0iregreg0ire changed the base branch from4.3 to4.4February 14, 2020 18:45
@greg0iregreg0ireforce-pushed theadd-missing-autoload-calls branch from2a40ba8 to94b5dbdCompareFebruary 14, 2020 18:47
@greg0ire
Copy link
ContributorAuthor

I picked 4.4 because 3.4 does not use the new type declarations.

greg0ire added a commit to greg0ire/DoctrineMongoDBBundle that referenced this pull requestFeb 14, 2020
A backwards-compatibility layer has been added to persistence to helpconsumers move to the new namespacing. It is based on class aliases,which means the type declaration changes should not be a BC-break: typesare the same.Seedoctrine/persistence#71This means:- using the new namespaces- adding autoload calls for new types to types that may be extended anduse persistence types in methods signatures for which compatibilitychecks may happen,so that signature compatibility is recognized by old versions of php.More details on this athttps://dev.to/greg0ire/how-to-deprecate-a-type-in-php-48cfFixesdoctrine#616 as a side effect, but the real fix is atsymfony/symfony#35728
greg0ire added a commit to greg0ire/DoctrineMongoDBBundle that referenced this pull requestFeb 14, 2020
A backwards-compatibility layer has been added to persistence to helpconsumers move to the new namespacing. It is based on class aliases,which means the type declaration changes should not be a BC-break: typesare the same.Seedoctrine/persistence#71This means:- using the new namespaces- adding autoload calls for new types to types that may be extended anduse persistence types in methods signatures for which compatibilitychecks may happen,so that signature compatibility is recognized by old versions of php.More details on this athttps://dev.to/greg0ire/how-to-deprecate-a-type-in-php-48cfFixesdoctrine#616 as a side effect, but the real fix is atsymfony/symfony#35728
greg0ire added a commit to greg0ire/DoctrineMongoDBBundle that referenced this pull requestFeb 14, 2020
A backwards-compatibility layer has been added to persistence to helpconsumers move to the new namespacing. It is based on class aliases,which means the type declaration changes should not be a BC-break: typesare the same.Seedoctrine/persistence#71This means:- using the new namespaces- adding autoload calls for new types to types that may be extended anduse persistence types in methods signatures for which compatibilitychecks may happen,so that signature compatibility is recognized by old versions of php.More details on this athttps://dev.to/greg0ire/how-to-deprecate-a-type-in-php-48cfFixesdoctrine#616 as a side effect, but the real fix is atsymfony/symfony#35728
@fabpot
Copy link
Member

Thank you@greg0ire.

fabpot added a commit that referenced this pull requestFeb 15, 2020
This PR was merged into the 4.4 branch.Discussion----------Add missing autoload callsUntil either php 7.4 or doctrine/persistence 2 is required, these willbe needed to make sure php recognises signatures using the old names ascompatible with signatures using the new names.This is necessary for types defined outside Symfony that extend typesfrom Symfony and still use the old names in signatures of methods theyoverride.Fixesdoctrine/DoctrineMongoDBBundle#616| Q             | A| ------------- | ---| Branch?       | 4.3| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       |Fixdoctrine/DoctrineMongoDBBundle#616| License       | MIT| Doc PR        | n/a<!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/releases): - Always add tests and ensure they pass. - Never break backward compatibility (seehttps://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch master.-->This topic is fairly complicated, more details athttps://dev.to/greg0ire/how-to-deprecate-a-type-in-php-48cfCommits-------94b5dbd Add missing autoload calls
@fabpotfabpot merged commit94b5dbd intosymfony:4.4Feb 15, 2020
@greg0iregreg0ire deleted the add-missing-autoload-calls branchFebruary 15, 2020 16:49
This was referencedFeb 29, 2020
greg0ire added a commit to greg0ire/DoctrineMongoDBBundle that referenced this pull requestMar 15, 2020
A backwards-compatibility layer has been added to persistence to helpconsumers move to the new namespacing. It is based on class aliases,which means the type declaration changes should not be a BC-break: typesare the same.Seedoctrine/persistence#71This means:- using the new namespaces- adding autoload calls for new types to types that may be extended anduse persistence types in methods signatures for which compatibilitychecks may happen,so that signature compatibility is recognized by old versions of php.More details on this athttps://dev.to/greg0ire/how-to-deprecate-a-type-in-php-48cfFixesdoctrine#616 as a side effect, but the real fix is atsymfony/symfony#35728
fabpot added a commit that referenced this pull requestNov 27, 2020
…ire)This PR was merged into the 5.2 branch.Discussion----------[DoctrineBridge] Require doctrine/persistence 2| Q             | A| ------------- | ---| Branch       | 5.x| Bug fix      | no| New feature  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       | n/a| License       | MIT| Doc PR        | n/aThis allows us to remove autoload calls that are necessary for thepersistence 1 backwards-compatibility layer to work.This is a follow up of#35728Commits-------574a184 Require doctrine/persistence 2
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@stofstofstof approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@greg0ire@nicolas-grekas@fabpot@stof@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp