Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Add missing autoload calls#35728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
8551073 to2a40ba8Comparestof approved these changesFeb 14, 2020
Member
nicolas-grekas commentedFeb 14, 2020
4.3 is EOLed. |
Until either php 7.4 or doctrine/persistence 2 is required, these willbe needed to make sure php recognises signatures using the old names ascompatible with signatures using the new names.This is necessary for types defined outside Symfony that extend typesfrom Symfony and still use the old names in signatures of methods theyoverride.More details athttps://dev.to/greg0ire/how-to-deprecate-a-type-in-php-48cfFixesdoctrine/DoctrineMongoDBBundle#616
2a40ba8 to94b5dbdCompareContributorAuthor
greg0ire commentedFeb 14, 2020
I picked 4.4 because 3.4 does not use the new type declarations. |
greg0ire added a commit to greg0ire/DoctrineMongoDBBundle that referenced this pull requestFeb 14, 2020
A backwards-compatibility layer has been added to persistence to helpconsumers move to the new namespacing. It is based on class aliases,which means the type declaration changes should not be a BC-break: typesare the same.Seedoctrine/persistence#71This means:- using the new namespaces- adding autoload calls for new types to types that may be extended anduse persistence types in methods signatures for which compatibilitychecks may happen,so that signature compatibility is recognized by old versions of php.More details on this athttps://dev.to/greg0ire/how-to-deprecate-a-type-in-php-48cfFixesdoctrine#616 as a side effect, but the real fix is atsymfony/symfony#35728
greg0ire added a commit to greg0ire/DoctrineMongoDBBundle that referenced this pull requestFeb 14, 2020
A backwards-compatibility layer has been added to persistence to helpconsumers move to the new namespacing. It is based on class aliases,which means the type declaration changes should not be a BC-break: typesare the same.Seedoctrine/persistence#71This means:- using the new namespaces- adding autoload calls for new types to types that may be extended anduse persistence types in methods signatures for which compatibilitychecks may happen,so that signature compatibility is recognized by old versions of php.More details on this athttps://dev.to/greg0ire/how-to-deprecate-a-type-in-php-48cfFixesdoctrine#616 as a side effect, but the real fix is atsymfony/symfony#35728
greg0ire added a commit to greg0ire/DoctrineMongoDBBundle that referenced this pull requestFeb 14, 2020
A backwards-compatibility layer has been added to persistence to helpconsumers move to the new namespacing. It is based on class aliases,which means the type declaration changes should not be a BC-break: typesare the same.Seedoctrine/persistence#71This means:- using the new namespaces- adding autoload calls for new types to types that may be extended anduse persistence types in methods signatures for which compatibilitychecks may happen,so that signature compatibility is recognized by old versions of php.More details on this athttps://dev.to/greg0ire/how-to-deprecate-a-type-in-php-48cfFixesdoctrine#616 as a side effect, but the real fix is atsymfony/symfony#35728
fabpot approved these changesFeb 15, 2020
Member
fabpot commentedFeb 15, 2020
Thank you@greg0ire. |
fabpot added a commit that referenced this pull requestFeb 15, 2020
This PR was merged into the 4.4 branch.Discussion----------Add missing autoload callsUntil either php 7.4 or doctrine/persistence 2 is required, these willbe needed to make sure php recognises signatures using the old names ascompatible with signatures using the new names.This is necessary for types defined outside Symfony that extend typesfrom Symfony and still use the old names in signatures of methods theyoverride.Fixesdoctrine/DoctrineMongoDBBundle#616| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets |Fixdoctrine/DoctrineMongoDBBundle#616| License | MIT| Doc PR | n/a<!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/releases): - Always add tests and ensure they pass. - Never break backward compatibility (seehttps://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch master.-->This topic is fairly complicated, more details athttps://dev.to/greg0ire/how-to-deprecate-a-type-in-php-48cfCommits-------94b5dbd Add missing autoload calls
greg0ire added a commit to greg0ire/DoctrineMongoDBBundle that referenced this pull requestMar 15, 2020
A backwards-compatibility layer has been added to persistence to helpconsumers move to the new namespacing. It is based on class aliases,which means the type declaration changes should not be a BC-break: typesare the same.Seedoctrine/persistence#71This means:- using the new namespaces- adding autoload calls for new types to types that may be extended anduse persistence types in methods signatures for which compatibilitychecks may happen,so that signature compatibility is recognized by old versions of php.More details on this athttps://dev.to/greg0ire/how-to-deprecate-a-type-in-php-48cfFixesdoctrine#616 as a side effect, but the real fix is atsymfony/symfony#35728
fabpot added a commit that referenced this pull requestNov 27, 2020
…ire)This PR was merged into the 5.2 branch.Discussion----------[DoctrineBridge] Require doctrine/persistence 2| Q | A| ------------- | ---| Branch | 5.x| Bug fix | no| New feature | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets | n/a| License | MIT| Doc PR | n/aThis allows us to remove autoload calls that are necessary for thepersistence 1 backwards-compatibility layer to work.This is a follow up of#35728Commits-------574a184 Require doctrine/persistence 2
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Until either php 7.4 or doctrine/persistence 2 is required, these will
be needed to make sure php recognises signatures using the old names as
compatible with signatures using the new names.
This is necessary for types defined outside Symfony that extend types
from Symfony and still use the old names in signatures of methods they
override.
Fixesdoctrine/DoctrineMongoDBBundle#616
This topic is fairly complicated, more details athttps://dev.to/greg0ire/how-to-deprecate-a-type-in-php-48cf