Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] Set previous exception when rethrown from controller resolver#35722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:3.4fromdanut007ro:controller_invalid_argument_exceptionFeb 15, 2020
Merged
[HttpKernel] Set previous exception when rethrown from controller resolver#35722
fabpot merged 1 commit intosymfony:3.4fromdanut007ro:controller_invalid_argument_exceptionFeb 15, 2020
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
fabpot approved these changesFeb 15, 2020
ab06cd9 to87d51c1CompareMember
fabpot commentedFeb 15, 2020
Thank you@danut007ro. |
fabpot added a commit that referenced this pull requestFeb 15, 2020
…troller resolver (danut007ro)This PR was submitted for the 4.4 branch but it was merged into the 3.4 branch instead.Discussion----------[HttpKernel] Set previous exception when rethrown from controller resolver| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | no| Deprecations? | no| License | MITIf an `\InvalidArgumentException` is catched by ControllerResolver a new one is thrown. The old exception is not added as `previous` parameter on the new one so it is not visible on the exception page. This pull request adds old exception as previous on the new one, so it is also visible on the exception page.Thank you.Commits-------87d51c1 Set previous exception when rethrown from controller resolver
This was referencedFeb 29, 2020
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an
\InvalidArgumentExceptionis catched by ControllerResolver a new one is thrown. The old exception is not added aspreviousparameter on the new one so it is not visible on the exception page. This pull request adds old exception as previous on the new one, so it is also visible on the exception page.Thank you.