Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[String] Transliterate & to and#35689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Warxcell commentedFeb 12, 2020
Q | A |
---|---|
Branch? | 5.0 |
Bug fix? | kind of |
New feature? | no |
Deprecations? | no |
Tickets | |
License | MIT |
Doc PR |
Can you please add a test case? |
@nicolas-grekas I think it's also a good idea to be able to add custom behaviour in that slugger (for such replacements). I was thinking about callback. What do you think? |
I don't think it's needed: decoration alreadt allows implementing custom behaviors to me. |
Thank you@Warxcell. |
This PR was submitted for the 5.0 branch but it was squashed and merged into the 5.1-dev branch instead.Discussion----------[String] Transliterate & to and| Q | A| ------------- | ---| Branch? | 5.0| Bug fix? | kind of| New feature? | no| Deprecations? | no| Tickets || License | MIT| Doc PR |Commits-------76ff984 [String] Transliterate & to and
@nicolas-grekas kinda. You have to make your own instance of
|
yes |
Warxcell commentedFeb 13, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@nicolas-grekas no, not exactly. on return point everything is now replaced by $separator - it's too late to do anything else on this string. |
Oh, indeed. The |