Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[HttpKernel] Make ErrorListener unaware of the event dispatcher#35635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:masterfromderrabus:improvement/make-error-listener-unaware-of-edFeb 8, 2020
Merged
[HttpKernel] Make ErrorListener unaware of the event dispatcher#35635
fabpot merged 1 commit intosymfony:masterfromderrabus:improvement/make-error-listener-unaware-of-edFeb 8, 2020
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
nicolas-grekas approved these changesFeb 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
with one minor comment
Uh oh!
There was an error while loading.Please reload this page.
8c8ae6f toa9d1dedCompareDone. The Travis failure looks unrelated. |
Tobion approved these changesFeb 8, 2020
fabpot approved these changesFeb 8, 2020
Thank you@derrabus. |
fabpot added a commit that referenced this pull requestFeb 8, 2020
…ispatcher (derrabus)This PR was merged into the 5.1-dev branch.Discussion----------[HttpKernel] Make ErrorListener unaware of the event dispatcher| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | N/A| License | MIT| Doc PR | N/AUnder certain circumstances, HttpKernel's `ErrorListener` class might dynamically register and unregister a listener with the dispatcher. If our goal is to make the dispatcher immutable, that specific behavior would be in our way. Also,#34988 would break this workflow.This PR provides an alternative. The listener is always registered, but I'm using the request to piggyback a flag that activates/deactivates the listener.Commits-------a9d1ded [HttpKernel] Make ErrorListener unaware of the event dispatcher.
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under certain circumstances, HttpKernel's
ErrorListenerclass might dynamically register and unregister a listener with the dispatcher. If our goal is to make the dispatcher immutable, that specific behavior would be in our way. Also,#34988 would break this workflow.This PR provides an alternative. The listener is always registered, but I'm using the request to piggyback a flag that activates/deactivates the listener.