Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Serializer] Serialization versioning#35617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ArnaudTarroux
Copy link

@ArnaudTarrouxArnaudTarroux commentedFeb 6, 2020
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#30848
LicenseMIT
Doc PRn/a

Add Serialization versioning.

  • Added@Since annotation
  • Added@Until annotation
  • Added support ofsince anduntil to thexml andyaml mapping
  • Addedversion context option
  • Added the possibility to configure theserializer.default_version in the framework config

ro0NL, Jibbarth, Koc, achasseux, dunglas, kayue, YaFou, and yceruto reacted with thumbs up emoji
@ro0NLro0NL mentioned this pull requestJun 4, 2020
@fabpot
Copy link
Member

@ArnaudTarroux Are you still motivated to work on this feature?

@ArnaudTarroux
Copy link
Author

@ArnaudTarroux Are you still motivated to work on this feature?

@fabpot Yes I am, I can work on it next week

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, looks good to me. There is a pending question on the issue: how will one set the current version on real apps?

@ArnaudTarroux
Copy link
Author

Thanks, looks good to me. There is a pending question on the issue: how will one set the current version on real apps?

@nicolas-grekas In the serialization context with the keyversion

@nicolas-grekas
Copy link
Member

In the serialization context with the key version

do you think we need a config option to set the defaultversion context?

@ArnaudTarrouxArnaudTarrouxforce-pushed thefeature/serializer-version branch from0ba9401 to834c1d9CompareAugust 31, 2020 19:56
@ArnaudTarroux
Copy link
Author

In the serialization context with the key version

do you think we need a config option to set the defaultversion context?

Yes maybe in some cases it might be useful. I'll implement it 👍

@ArnaudTarroux
Copy link
Author

ArnaudTarroux commentedSep 1, 2020
edited
Loading

Thanks, looks good to me. There is a pending question on the issue: how will one set the current version on real apps?

@nicolas-grekas thank for you review.
I've made some changes following your advices, includingversion_compare() instead ofComposer/Semver.
And I've added the possibility to configure the default version in the framework config (serializer.default_version).

Copy link
Member

@ycerutoyceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

For consistency.

ArnaudTarroux reacted with thumbs up emoji
@fabpotfabpot closed thisOct 7, 2020
@fabpot
Copy link
Member

We've just moved away frommaster as the main branch to use5.x instead. Unfortunately, I cannot reopen the PR and change the target branch to5.x. Can you open a new PR referencing this one to not loose the discussion? Thank you for your understanding and for your help.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@ycerutoycerutoyceruto left review comments

@dunglasdunglasAwaiting requested review from dunglas

Assignees
No one assigned
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

6 participants
@ArnaudTarroux@fabpot@nicolas-grekas@dunglas@yceruto@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp