Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Workflow] Make method signature compatible with 4.4#35616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lyrixx merged 1 commit intosymfony:5.0frompbowyer:patch-2
Feb 6, 2020
Merged

[Workflow] Make method signature compatible with 4.4#35616

lyrixx merged 1 commit intosymfony:5.0frompbowyer:patch-2
Feb 6, 2020

Conversation

@pbowyer
Copy link
Contributor

@pbowyerpbowyer commentedFeb 6, 2020
edited by lyrixx
Loading

QA
Branch?5.0
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#35615
LicenseMIT
Doc PRsymfony/symfony-docs#...

A method signature changed in a non-backwards-compatible way in 5.0.0 - and in only one class. This commit fixes that - and has been tested.

For full details see ticket#35615.

@nicolas-grekasnicolas-grekas added this to the5.0 milestoneFeb 6, 2020
@lyrixx
Copy link
Member

Good catch, thanks Peter.

lyrixx added a commit that referenced this pull requestFeb 6, 2020
…yer)This PR was squashed before being merged into the 5.0 branch (closes#35616).Discussion----------[Workflow] Make method signature compatible with 4.4| Q             | A| ------------- | ---| Branch?       | 5.0 <!-- see below -->| Bug fix?      | yes| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       |Fix#35615  <!-- prefix each issue number with "Fix #", if any -->| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features --><!--Replace this notice by a short README for your feature/bugfix. This will help peopleunderstand your PR and can be used as a start for the documentation.Additionally (seehttps://symfony.com/roadmap): - Always add tests and ensure they pass. - Never break backward compatibility (seehttps://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch master.-->A method signature changed in a non-backwards-compatible way in 5.0.0 - and in only one class. This commit fixes that - and has been tested.For full details see ticket#35615.Commits-------474be96 [Workflow] Make method signature compatible with 4.4
@lyrixxlyrixx merged commit474be96 intosymfony:5.0Feb 6, 2020
@fabpotfabpot mentioned this pull requestFeb 29, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@lyrixxlyrixxlyrixx approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@pbowyer@lyrixx@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp