NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

Fix Contracts autoloader typo#35610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:masterfromIonBazan:patch-2

Feb 6, 2020

Merged

Fix Contracts autoloader typo#35610

nicolas-grekas merged 1 commit intosymfony:masterfromIonBazan:patch-2

Feb 6, 2020

Conversation

Copy link

Contributor

IonBazan commentedFeb 6, 2020

Q	A
Branch?	master
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#35526
License	MIT

Autoloader does not include new Deprecation component when installingsymfony/contracts due totypo.

Steps to reproduce:

composer dump-autoload -acat vendor/composer/autoload_files.php

Produces:

<?php// autoload_files.php @generated by Composer$vendorDir = dirname(dirname(__FILE__));$baseDir = dirname($vendorDir);return array(    '0e6d7bf4a5811bfa5cf40c5ccd6fae6a' => $vendorDir . '/symfony/polyfill-mbstring/bootstrap.php',    '25072dd6e2470089de65ae7bf11d3109' => $vendorDir . '/symfony/polyfill-php72/bootstrap.php',    'f598d06aa772fa33d905e87be6398fb1' => $vendorDir . '/symfony/polyfill-intl-idn/bootstrap.php',);

Fix Contracts autoloader typo

d5bcaff

carsonbot added Status: Needs Review Bug labels

Feb 6, 2020

IonBazan requested a review fromnicolas-grekas

February 6, 2020 03:15

nicolas-grekas approved these changes

Feb 6, 2020

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Feb 6, 2020

nicolas-grekas added this to thenext milestone

Feb 6, 2020

Copy link

Member

nicolas-grekas commentedFeb 6, 2020

Thank you@IonBazan.

nicolas-grekas added a commit that referenced this pull request

Feb 6, 2020

minor#35610Fix Contracts autoloader typo (IonBazan)

8a87490

This PR was merged into the 5.1-dev branch.Discussion----------Fix Contracts autoloader typo| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#35526| License       | MITAutoloader does not include new Deprecation component when installing `symfony/contracts` due to [typo](https://getcomposer.org/doc/04-schema.md#files).Steps to reproduce:```composer dump-autoload -acat vendor/composer/autoload_files.php```Produces:```<?php// autoload_files.php@generated by Composer$vendorDir = dirname(dirname(__FILE__));$baseDir = dirname($vendorDir);return array(    '0e6d7bf4a5811bfa5cf40c5ccd6fae6a' => $vendorDir . '/symfony/polyfill-mbstring/bootstrap.php',    '25072dd6e2470089de65ae7bf11d3109' => $vendorDir . '/symfony/polyfill-php72/bootstrap.php',    'f598d06aa772fa33d905e87be6398fb1' => $vendorDir . '/symfony/polyfill-intl-idn/bootstrap.php',);```Commits-------d5bcaff Fix Contracts autoloader typo