Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Security] Replace 403 with 401 inonAuthenticationFailure method#35606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromalanpoulain:fix-authentication-failure-docFeb 5, 2020
Merged
[Security] Replace 403 with 401 inonAuthenticationFailure method#35606
nicolas-grekas merged 1 commit intosymfony:3.4fromalanpoulain:fix-authentication-failure-docFeb 5, 2020
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
chalasr approved these changesFeb 5, 2020
Note for mergers: When merging this up to master, the patch should be applied to the |
Thank you@alanpoulain. |
nicolas-grekas added a commit that referenced this pull requestFeb 5, 2020
…ure` method (alanpoulain)This PR was merged into the 3.4 branch.Discussion----------[Security] Replace 403 with 401 in `onAuthenticationFailure` method| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | N/A| License | MIT| Doc PR | N/AThis comment in `onAuthenticationFailure` was misleading since a 401 status code should probably be returned instead of a 403.Commits-------73bc793 Replace 403 with 401 in onAuthenticationFailure method
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comment in
onAuthenticationFailurewas misleading since a 401 status code should probably be returned instead of a 403.