Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Config][XmlReferenceDumper] Prevent potential \TypeError#35537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@fancyweb
Copy link
Contributor

@fancywebfancyweb commentedJan 31, 2020•
edited
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets#34841
LicenseMIT
Doc PR-

$key can be null andsetName() is now typed withstring. Fallbacking on an empty string restores the behavior (and output) of < 5.0.

However, that shows that's a case we don't handle (yet) properly. But that's another task 😃

@nicolas-grekas
Copy link
Member

We don't handle dumping null names, that's what you mean? Any suggestions?
Worth a test case?
Shouldn't this be merged in 4.4?

@fancyweb
Copy link
ContributorAuthor

fancyweb commentedFeb 3, 2020•
edited
Loading

We don't handle dumping null names, that's what you mean?

We don't handle aPrototypedArrayNode that has no key attribute and that have anotherPrototypedArrayNode as its child.

Worth a test case?

I don't think so. A test should be added once we support it.

Shouldn't this be merged in 4.4?

No because thestring arg type onsetName() was added in 5.0.

@fancywebfancyweb changed the base branch from5.0 to4.4February 3, 2020 17:10
@fancywebfancywebforce-pushed theconfig-fix-xml-reference-dumper branch from998b53e toe8ba15eCompareFebruary 3, 2020 17:10
@nicolas-grekas
Copy link
Member

Thank you@fancyweb.

nicolas-grekas added a commit that referenced this pull requestFeb 3, 2020
…(fancyweb)This PR was merged into the 4.4 branch.Discussion----------[Config][XmlReferenceDumper] Prevent potential \TypeError| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |#34841| License       | MIT| Doc PR        | -`$key` can be null and `setName()` is now typed with `string`. Fallbacking on an empty string restores the behavior (and output) of < 5.0.However, that shows that's a case we don't handle (yet) properly. But that's another task 😃Commits-------e8ba15e [Config][XmlReferenceDumper] Prevent potential \TypeError
@nicolas-grekasnicolas-grekas merged commite8ba15e intosymfony:4.4Feb 3, 2020
@fancywebfancyweb deleted the config-fix-xml-reference-dumper branchFebruary 3, 2020 17:15
This was referencedFeb 29, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@fancyweb@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp