Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Intl] Provide more locale translations#35517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| "en":"Engels", | ||
| "en_001":"Engels (Wêreld)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
from a user perspective, this creates 2 entries in the Locale form type. It may be confusing 🤔 but i tend to believe it should be filtered manually, if desired.
ie.en (no region) vsen_001 (world region) could be considered equivalent, whereas the first may assume 001 for a region implicitly ... but that's outside our domain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
so the user may select en_001 to explicitly provide a region and opt out from some specific region (hence "world"), whereas in case of "en" the app may assume any region.
Fine as-is for me 👍
fabpot commentedJan 30, 2020
Merging into 4.4 as 4.3 ends of maintenance is tomorrow and this PR might be a slight behavior change. |
fabpot commentedJan 30, 2020
Thank you@ro0NL. |
This PR was submitted for the 4.3 branch but it was merged into the 4.4 branch instead (closes#35517).Discussion----------[Intl] Provide more locale translations| Q | A| ------------- | ---| Branch? | 4.3| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |Fix#35513 (comment)| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->This enables more locale translations, available upstream, which are valid. In this case esp. locales with a numeric region code, eg. `es_419`This should return true in `Locales::exists()`, which is currently not the case. By providing the translation, it implicitly exists as well.cc@jkobusCommits-------27cc120 [Intl] Provide more locale translations
jkobus commentedJan 31, 2020
Thanks@ro0NL. |
Uh oh!
There was an error while loading.Please reload this page.
This enables more locale translations, available upstream, which are valid. In this case esp. locales with a numeric region code, eg.
es_419This should return true in
Locales::exists(), which is currently not the case. By providing the translation, it implicitly exists as well.cc@jkobus