Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Console] Add constants for main exit codes#35478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromChi-teck:exit-codes
Jan 29, 2020

Conversation

Chi-teck
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#35431
LicenseMIT

BafS, metaer, and PululuK reacted with thumbs up emoji
@Chi-teck
Copy link
ContributorAuthor

Can we use these constants in console's own code?

Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd preferEXIT_ERROR instead ofEXIT_FAILURE ... but "failure" seems to be the standard word for this (e.g.https://www.gnu.org/software/libc/manual/html_node/Exit-Status.html)

Thanks@Chi-teck!

@fabpot
Copy link
Member

What about justCommand::SUCCESS andCommand::FAILURE?
I would not use these constants in Symfony's code.

juliusstoerrle and lyrixx reacted with thumbs up emoji

@@ -29,6 +29,9 @@
*/
class Command
{
const SUCCESS = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

public const 👍🏻

@fabpot
Copy link
Member

Thank you@Chi-teck.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

[Console] Define constants for main exit codes.
7 participants
@Chi-teck@fabpot@javiereguiluz@OskarStark@nicolas-grekas@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp