Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Workflow] Added parameter type hinting where possible.#35434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
fre5h wants to merge2 commits intosymfony:masterfromfre5h:workflow-type-hinting

Conversation

@fre5h
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?no
Deprecations?no
TicketsRelated to#32223
LicenseMIT
Doc PRno

According to#32223 were added type hintings in most classes, but not in all possible. I tried to add more type hintings. Most of my changes look reasonable, but I am not sure in every.

If you find, that in some class/method type hintings are not welcome, then notice it and I will remove it.
If you find, that all my changes are senseless, then just close this pull request :)

Copy link
Contributor

@ro0NLro0NL left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

i thought we did do return types automatically ...#33236 or why did we miss those initially?

@lyrixx
Copy link
Member

lyrixx commentedJan 22, 2020•
edited
Loading

why did we miss those initially?

I don't think so.

Thanks@fre5h for your PR but Most of your change break the BC promise

refs:

@lyrixx
Copy link
Member

About the:void on private method (the only changes that does not break BC), it does not bring anything useful.

I'm sorry, But I'm gonna close your PR because It cannot be merged.

@lyrixxlyrixx closed thisJan 22, 2020
@fre5hfre5h deleted the workflow-type-hinting branchJanuary 22, 2020 13:14
@ro0NL
Copy link
Contributor

@lyrixx so we missed those because they break BC :) i see.

lyrixx and fre5h reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lyrixxlyrixxAwaiting requested review from lyrixx

1 more reviewer

@ro0NLro0NLro0NL left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fre5h@lyrixx@ro0NL@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp