Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DI] CheckTypeDeclarationsPass now checks if value is type of parameter type#35429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4frompfazzi:issue_35420
Jan 27, 2020

Conversation

pfazzi
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets#35420
LicenseMIT

@nicolas-grekasnicolas-grekas changed the base branch frommaster to4.4January 22, 2020 08:35
@nicolas-grekasnicolas-grekas added this to the4.4 milestoneJan 22, 2020
@nicolas-grekasnicolas-grekas changed the titleIssue 35420[DI] CheckTypeDeclarationsPass now checks if value is type of parameter typeJan 22, 2020
@nicolas-grekas
Copy link
Member

Can you provide a reproducer for the issue? Maybe a test case?
There is already such a check when $value is a Definition.
Which triggers this: what's the type/class of $value in your case and more importantly how does it get there?

@pfazzi
Copy link
ContributorAuthor

pfazzi commentedJan 22, 2020•
edited
Loading

Yes i can. Let me anticipate you that error happens when$value is not aDefinition but instance ofSymfony\Component\ExpressionLanguage\Expression

nicolas-grekas reacted with thumbs up emoji

@pfazzi
Copy link
ContributorAuthor

@nicolas-grekas I have just integrated a test case

@nicolas-grekasnicolas-grekasforce-pushed theissue_35420 branch 2 times, most recently fromd64a00b to89cfb0bCompareJanuary 25, 2020 14:30
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(I pushed some changes on your fork to make the code less error-prone)

@nicolas-grekas
Copy link
Member

Thank you@pfazzi.

pfazzi reacted with thumbs up emoji

nicolas-grekas added a commit that referenced this pull requestJan 27, 2020
… of parameter type (pfazzi)This PR was merged into the 4.4 branch.Discussion----------[DI]  CheckTypeDeclarationsPass now checks if value is type of parameter type| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |#35420| License       | MITCommits-------0d4c0a6 [DI]  CheckTypeDeclarationsPass now checks if value is type of parameter type
@nicolas-grekasnicolas-grekas merged commit0d4c0a6 intosymfony:4.4Jan 27, 2020
This was referencedJan 31, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

3 participants
@pfazzi@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp