There is no support forlabel_format yet. I have no idea about how get%id% substitution value inViolationMapper.

I think this would need some examples - via tests maybe. Reviewing I'm wondering e.g. why doesn't the message go through translation? Why do we use str_replace instead of "label" as a translation variable? Should translating the label be done before or after humanize() by form? etc. All these may become more obvious with examples.

Why doesn't the message go through translation?

Message into violation object already translated.

Why do we use str_replace instead of "label" as a translation variable?

Since the message has already been translated, it makes no sense to translate it one more time with{{ label }} parameter. IMO str_replace is quite enough. (But maybe I'm not taking something into account.)

Should translating the label be done before or after humanize() by form?

There I've repeated translation logic fromform_div_layout.html.twig because we want to get the same label as it rendered on form.

Maybe placeholder should be%label% for consistence with substitutions format inlabel_format widget option?

@nicolas-grekas what can I do to bring the review closer?

Any news on this pull request?

@nicolas-grekas@xabbuh PR rebased on master and ready for review.

@xabbuh Could you review this PR?

Thank you@a-menshchikov.

@a-menshchikov Can you submit a PR for the docs?