Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpClient] Fix strict parsing of response status codes#35324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.3fromArmando-Torres:fix/httpclient-strict-response-status-codes
Jan 13, 2020
Merged

[HttpClient] Fix strict parsing of response status codes#35324

nicolas-grekas merged 1 commit intosymfony:4.3fromArmando-Torres:fix/httpclient-strict-response-status-codes
Jan 13, 2020

Conversation

@Armando-Torres
Copy link

QA
Branch?5.0
Bug fix?yes
New feature?no
Deprecations?no
TicketsNo ticket opened
LicenseMIT
Doc PRNo new feature

If you wait a strict Http code response by the server were you request, but the server response isn't strict and only return HTTP/1.1 200 we have a problem without sense to be strict on regular expression.

@nicolas-grekas
Copy link
Member

I'm not sure about\s. Does your server use a tab? Or does it only miss the trailing space?
Not that HTTP mandates the trailing space, but I get we can accept ending with the code.

@nicolas-grekasnicolas-grekas added this to the4.3 milestoneJan 13, 2020
@nicolas-grekasnicolas-grekas changed the titleFix/httpclient strict response status codes[HttpClient] Fix strict parsing of response status codesJan 13, 2020
@nicolas-grekasnicolas-grekas changed the base branch frommaster to4.3January 13, 2020 17:23
@nicolas-grekas
Copy link
Member

Thank you @Armando-Walmeric.

nicolas-grekas added a commit that referenced this pull requestJan 13, 2020
…Armando-Walmeric)This PR was submitted for the master branch but it was squashed and merged into the 4.3 branch instead.Discussion----------[HttpClient] Fix strict parsing of response status codes| Q             | A| ------------- | ---| Branch?       | 5.0| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | No ticket opened| License       | MIT| Doc PR        | No new featureIf you wait a strict Http code response by the server were you request, but the server response isn't strict and only return HTTP/1.1 200 we have a problem without sense to be strict on regular expression.Commits-------4aa9536 [HttpClient] Fix strict parsing of response status codes
@nicolas-grekasnicolas-grekas merged commit4aa9536 intosymfony:4.3Jan 13, 2020
@nicolas-grekas
Copy link
Member

Merged into 4.3, will come to upper branches once we merge 4.3 up.

@Armando-TorresArmando-Torres deleted the fix/httpclient-strict-response-status-codes branchJanuary 13, 2020 17:30
This was referencedJan 21, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@dunglasdunglasAwaiting requested review from dunglas

@lyrixxlyrixxAwaiting requested review from lyrixx

@srozesrozeAwaiting requested review from sroze

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

3 participants

@Armando-Torres@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp