Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Workflow] Make many internal services as hidden#35321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromlyrixx:w-hidden
Jan 13, 2020

Conversation

lyrixx
Copy link
Member

@lyrixxlyrixx commentedJan 13, 2020•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#35197
LicenseMIT
Doc PR

I "removed":

  • transitions
  • auto-generated guard listener (when enable via the configuration)
  • auto-generated audit trail listener (when enable via the configuration)

I kept

  • the registry
  • the workflow (of course)
  • its definition: I know people are using it
  • workflow.twig_extension the twig extension because all others twig extensions are not hidden - but could IMHO
  • the default marking store
  • the command to dump the workflow (SVG)
  • The local expression language
  • abstract workflow definition for the workflow and state machine

@nicolas-grekasnicolas-grekas added this to thenext milestoneJan 13, 2020
@nicolas-grekas
Copy link
Member

For the generated ids, I think this is OK, but for the static names, isn't this a BC break?

@lyrixx
Copy link
MemberAuthor

For the generated ids, I think this is OK, but for the static names, isn't this a BC break?

I don't know. You tell me :)

@lyrixx
Copy link
MemberAuthor

For the generated ids, I think this is OK, but for the static names, isn't this a BC break?

reverted

@fabpot
Copy link
Member

Thank you@lyrixx.

fabpot added a commit that referenced this pull requestJan 13, 2020
This PR was merged into the 5.1-dev branch.Discussion----------[Workflow] Make many internal services as hidden| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       |Fix#35197| License       | MIT| Doc PR        |I "removed":* transitions* auto-generated guard listener  (when enable via the configuration)* auto-generated audit trail listener (when enable via the configuration)* abstract workflow definition for the workflow and state machineI kept* the registry* the workflow (of course)* its definition: I know people are using it* `workflow.twig_extension` the twig extension because all others twig extensions are not hidden - but could IMHO* the default marking store* the command to dump the workflow (SVG)* The local expression languageCommits-------b4776d6 [Workflow] Make many internal services as hidden
@fabpotfabpot merged commitb4776d6 intosymfony:masterJan 13, 2020
@lyrixxlyrixx deleted the w-hidden branchJanuary 13, 2020 13:59
@nicolas-grekasnicolas-grekas modified the milestones:next,5.1May 4, 2020
@fabpotfabpot mentioned this pull requestMay 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@stofstofstof left review comments

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

[Workflow] Hide internal services
5 participants
@lyrixx@nicolas-grekas@fabpot@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp