Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Make sure the UriSigner can be autowired#35298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

Toflar
Copy link
Contributor

@ToflarToflar commentedJan 10, 2020•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?no
Tickets
LicenseMIT
Doc PR

I wasn't able to find the correct spot where this is tested. Is it even tested and if so, can you point me as to where to add tests for that? Thanks 😄

ro0NL and andreybolonin reacted with thumbs up emoji
@nicolas-grekas
Copy link
Member

We don't have tests for these :)
PR should target master, that's a new feature.

@Toflar
Copy link
ContributorAuthor

Damn, I was sure it's going to be 3.4 😆 Okay, let me fix that real quick.

@ToflarToflarforce-pushed thefix-urisigner-not-autowirable branch from82914ff to9ad1caaCompareJanuary 10, 2020 11:00
@ToflarToflar changed the base branch from3.4 tomasterJanuary 10, 2020 11:00
@leofeyer
Copy link
Contributor

Is this really a new feature? We will not be able to autowire the URI signer in Symfony 4.4 then, will we?

@Toflar
Copy link
ContributorAuthor

Rebased, target branch fixed, description updated.

@fabpot
Copy link
Member

Thank you@Toflar.

fabpot added a commit that referenced this pull requestJan 10, 2020
This PR was merged into the 5.1-dev branch.Discussion----------Make sure the UriSigner can be autowired| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       || License       | MIT| Doc PR        |I wasn't able to find the correct spot where this is tested. Is it even tested and if so, can you point me as to where to add tests for that? Thanks 😄Commits-------9ad1caa Make sure the UriSigner can be autowired
@fabpotfabpot merged commit9ad1caa intosymfony:masterJan 10, 2020
@ToflarToflar deleted the fix-urisigner-not-autowirable branchJanuary 10, 2020 11:23
@xabbuh
Copy link
Member

@leofeyer You can still add the alias yourself if you would like to autowire theUriSigner, but do not want to wait for Symfony 5.1.

leofeyer reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas removed this from thenext milestoneMay 4, 2020
@nicolas-grekasnicolas-grekas added this to the5.1 milestoneMay 4, 2020
@fabpotfabpot mentioned this pull requestMay 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

@aschemppaschemppaschempp approved these changes

@dunglasdunglasAwaiting requested review from dunglas

@lyrixxlyrixxAwaiting requested review from lyrixx

@srozesrozeAwaiting requested review from sroze

@xabbuhxabbuhAwaiting requested review from xabbuh

Assignees
No one assigned
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

7 participants
@Toflar@nicolas-grekas@leofeyer@fabpot@xabbuh@aschempp@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp