NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[FrameworkBundle] TemplateController should accept extra arguments to be sent to the template#35257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:masterfromRebolon:rebolon/template-controller-add-context

Jan 10, 2020

Merged

[FrameworkBundle] TemplateController should accept extra arguments to be sent to the template#35257

fabpot merged 1 commit intosymfony:masterfromRebolon:rebolon/template-controller-add-context

Jan 10, 2020

Conversation

Copy link

Rebolon commentedJan 8, 2020•
edited by yceruto
Loading

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	Fix #...
License	MIT
Doc PR	symfony/symfony-docs#...

In the official documentation (symfony.com/doc/master/templates.html#rendering-a-template-directly-from-a-route) it says that TemplateController should accept extra arguments. In fact it's not available for instance.
So i added the context argument as an array. Because of deprecation of templating, only the twig instance will apply the context argument.

It will need to be implemented in branch 5.

The following issue has been created in documentation project :symfony/symfony-docs#12897

carsonbot added Status: Needs Review FrameworkBundle Feature labels

Jan 8, 2020

Rebolon changed the base branch frommaster to4.4

January 8, 2020 11:25

yceruto requested changes

Jan 8, 2020

View reviewed changes

Copy link

Member

yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi@Rebolon, thanks for taking care of this. I left some comments to make your "first contribution" happy :)

The target branch must bemaster for new features (future 5.1),4.4 is already released and must be used for bugfix only. Please, rebase it tomaster.
A functional test case is required for new features like this one.

Don't hesite to ask any question, thanks again.

src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md OutdatedShow resolvedHide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels

Jan 8, 2020

yceruto added this to thenext milestone

Jan 8, 2020

Copy link

Author

Rebolon commentedJan 8, 2020

@yceruto thx for help.
Not sure to get time for the Functional Test. I understand the goal, but not sure how to achieve it throught this project in short time (i'm looking for it).

Copy link

Member

yceruto commentedJan 8, 2020

Not sure to get time for the Functional Test. I understand the goal, but not sure how to achieve it throught this project in short time (i'm looking for it).

Don't worry about it, I can add it at the end, just let me know when the other comments have been fixed. Thanks!

Rebolon requested review fromdunglas,lyrixx,sroze andxabbuh ascode owners

January 8, 2020 15:14

carsonbot added Status: Needs Review and removed Status: Needs Work labels

Jan 8, 2020

yceruto changed the base branch from4.4 tomaster

January 8, 2020 15:47

nicolas-grekas mentioned this pull request

Jan 8, 2020

[FrameworkBundle][Routing] added Configurators to handle template and redirect controllers#30501

Merged

4 tasks

Copy link

Author

Rebolon commentedJan 8, 2020

@yceruto it should be ok right now
I added an Integration Test as i needed Twig. If you consider you need a Functional Test, it's up to you, or just give me tips on the wished usage (WebTestCase or Panther, anything else)

Rebolon requested a review fromyceruto

January 8, 2020 17:06

Copy link

Member

yceruto commentedJan 8, 2020

Wow! you were fast ⚡ :)

An unit test is enough for me, but can you confirm that this is the new route config for this feature?

# config/routes.yamlacme_privacy:path:/privacycontroller:Symfony\Bundle\FrameworkBundle\Controller\TemplateControllerdefaults:template:'static/privacy.html.twig'maxAge:86400sharedAge:86400# optionally you can define some arguments passed to the templatecontext:site_name:'ACME'theme:'dark'