On symfony.com, we need to use HTTPlug for 3rd party libs. Whennyholm/psr7 is not installed, we currently see an exception sayingNo HTTPlug clients found. fromHttpClientDiscovery.

This fixes the message by correctly suggestingnyholm/psr7 instead, since thereis an HTTPlug client:HttplugClient from our HttpClient component.

It's quite unfortunate thatguzzle/psr7 provides no PSR17 factory yet, because that would have solved some part of this deps mess. /cc@Nyholm @sagikazarmark FYI
Note thathttps://packagist.org/providers/psr/http-factory-implementation listsguzzle/psr7 but this is a wrong solution: no tagged release of it is PSR17-compatible, which means installing it doesn't solve the issue.

[HttpClient] fix exception in case of PSR17 discovery failure

96e70a4

nicolas-grekas added this to the4.4 milestone

Jan 7, 2020

carsonbot added Status: Needs Review HttpClient Bug labels

Jan 7, 2020

Copy link

MemberAuthor

nicolas-grekas commentedJan 7, 2020

Hum, actually the message saysNo PSR-17 response factory found. Install a package from this list: https://packagist.org/providers/psr/http-factory-implementation.
The one aboutNo HTTPlug clients found. is from another dep that callsHttp\Discovery\HttpClientDiscovery::find().

This is a mess, sorry :)

nicolas-grekas closed this

Jan 7, 2020

nicolas-grekas deleted the hc-discovery-error branch

January 7, 2020 13:12

nicolas-grekas restored the hc-discovery-error branch

January 7, 2020 13:56

nicolas-grekas reopened this

Jan 7, 2020

Copy link

MemberAuthor

nicolas-grekas commentedJan 7, 2020

Reopening, the message is still better.

Nyholm approved these changes

Jan 7, 2020

View reviewed changes

Copy link

Member

Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree that this message is better and more helpful.

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jan 7, 2020

fabpot approved these changes

Jan 7, 2020

View reviewed changes

Copy link

Member

fabpot commentedJan 7, 2020

Thank you@nicolas-grekas.

fabpot added a commit that referenced this pull request

Jan 7, 2020

bug#35245[HttpClient] fix exception in case of PSR17 discovery fail…

9e7a410

…ure (nicolas-grekas)This PR was merged into the 4.4 branch.Discussion----------[HttpClient] fix exception in case of PSR17 discovery failure| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -On symfony.com, we need to use HTTPlug for 3rd party libs. When `nyholm/psr7` is not installed, we currently see an exception saying `No HTTPlug clients found.` from `HttpClientDiscovery`.This fixes the message by correctly suggesting `nyholm/psr7` instead, since there *is* an HTTPlug client: `HttplugClient` from our HttpClient component.It's quite unfortunate that `guzzle/psr7` provides no PSR17 factory yet, because that would have solved some part of this deps mess. /cc@Nyholm@sagikazarmark FYINote thathttps://packagist.org/providers/psr/http-factory-implementation lists `guzzle/psr7` but this is a wrong solution: no tagged release of it is PSR17-compatible, which means installing it doesn't solve the issue.Commits-------96e70a4 [HttpClient] fix exception in case of PSR17 discovery failure