Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle] Do not throw exception on value generate key#35099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:4.4fromjderusse:secret-genkey
Jan 9, 2020

Conversation

@jderusse
Copy link
Member

@jderussejderusse commentedDec 24, 2019
edited by nicolas-grekas
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsN/A
LicenseMIT
Doc PRN/A

When using env variable instead of key files and creating a new Secret, the check ingenerateKeys (called by the commandSecretsSetCommand) prevents generating a secret.

reproducer:

$ rm config/secrets/prod/prod.decrypt.private.php$ export SYMFONY_DECRYPTION_SECRET=XXX$ ./bin/console secret:set FOOIn SodiumVault.php line 50:                                                                                                 Cannot generate keys when a decryption key has been provided while instantiating the vault.

This PR converts the exception in a warning message.

@nicolas-grekasnicolas-grekas changed the titleDo not throw exception on valut generate key[FrameworkBundle] Do not throw exception on value generate keyDec 26, 2019
@nicolas-grekasnicolas-grekas added this to the4.4 milestoneDec 26, 2019
@nicolas-grekas
Copy link
Member

Thank you@jderusse.

nicolas-grekas added a commit that referenced this pull requestJan 9, 2020
… key (jderusse)This PR was merged into the 4.4 branch.Discussion----------[FrameworkBundle] Do not throw exception on value generate key| Q             | A| ------------- | ---| Branch?       | 4.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | N/A| License       | MIT| Doc PR        | N/AWhen using env variable instead of key files and creating a new Secret, the check in `generateKeys` (called by the command `SecretsSetCommand`) prevents generating a secret.reproducer:```$ rm config/secrets/prod/prod.decrypt.private.php$ export SYMFONY_DECRYPTION_SECRET=XXX$ ./bin/console secret:set FOOIn SodiumVault.php line 50:  Cannot generate keys when a decryption key has been provided while instantiating the vault.```This PR converts the exception in a warning message.Commits-------2f608b4 Do not throw exception on valut generate key
@nicolas-grekasnicolas-grekas merged commit2f608b4 intosymfony:4.4Jan 9, 2020
This was referencedJan 21, 2020
@jderussejderusse deleted the secret-genkey branchMarch 5, 2020 20:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@mazuxmazuxmazux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@jderusse@nicolas-grekas@mazux@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp