Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form] Update the 'post_max_size_message'#35013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Form] Update the 'post_max_size_message'#35013
Uh oh!
There was an error while loading.Please reload this page.
Conversation
stefanospetrakis commentedDec 17, 2019
This change would - probably - cause updating all the translations for this message; not sure how demanding that task would be, I couldn't translate all these on my own as part of this PR for sure. N.B.: Adding this as a draft PR since it is not complete due to this. |
ro0NL commentedDec 17, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Regarding the message, i agree it's incorrect and shouldnt assume "uploaded files" which ultimately is a subset of any "submitted content". See#31788 +#30931 regarding the topic of changing messages ... it's not simple indeed, so this PR may join the club :) I tend to believe we should switch the source code to use abstract message keys (i.e. English translations could be provided staticly, in case the Translator is unavailable, thus |
nicolas-grekas commentedDec 26, 2019
Instead of changing the source code, shouldn't we change the target in |
stefanospetrakis commentedDec 26, 2019
Yes, that would fix the output and the reported problem in the easiest way. I still think the original source/string is misleading and I would prefer to fix that in the code of the FormType class. Plus, the change in |
nicolas-grekas commentedFeb 5, 2020
I'm closing because:
Feels free to resubmit if you have a proposal to fix those issues. |
Small validation message update to avoid confusion when a form doesn't contain uploaded files and still results in a POST action with content that exceeds the
post_max_sizelimit of PHP.