Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] Added defaultinputmode attribute to Search, Email and Tel form types#34986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:masterfromfre5h:feature-inputmode
Dec 26, 2019

Conversation

fre5h
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?no
Ticketsno
LicenseMIT
Doc PRno

There is an HTML5 attributeinputmode. Seehttps://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/inputmode It is supported by most of mobile browsers.
There are such supported values forinputmode:

  • none
  • text (default value)
  • decimal
  • numeric
  • tel
  • search
  • email
  • url

Theurl inputmode is already implemented in UrlTypehttps://github.com/symfony/symfony/blob/master/src/Symfony/Component/Form/Extension/Core/Type/UrlType.php#L39

I propose to addtel,search,email as default form view attribute to the relevant form types. Why only these three?url is already implemented,none makes no sense as default value for any form type,text is a default input type for any browser.

decimal andnumeric has different behaviour on iOS. iOS doesn't show- (minus) sign on keyboard for these input modes. Of course in cases, when only positive numbers are expected, it is normal. But it is not suitable as default value in Symfony form type. Developers can add this attribute manually in their forms, if they need only positive numbers.

Butsearch,tel andemail input modes don't have problems and can be added as default attributes to Symfony form types. This will improve user experience, while using web-sites developed on Symfony on mobile devices. I add it into the *Type classes insidebuildView method, so it will be possible to override this parameter if needed.

If you are interested in how it looks like in mobile browsers, you can open this linkhttps://inputmodes.com/ on you mobile device.

Here are screenshots, how mobile keyboard looks like on Android and iOS with usinginputmode attribute.

tel inputmode

image

email inputmode

image

search inputmode

image

ro0NL, wbrframe, metalslave, javiereguiluz, and andyhobbs reacted with thumbs up emoji
@fre5h
Copy link
ContributorAuthor

CI is failed because it is failed in master branch too. Tests for From component have passed.

@nicolas-grekasnicolas-grekas added this to thenext milestoneDec 15, 2019
Copy link
Member

@javiereguiluzjaviereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Very nice! Thanks@fre5h.

@nicolas-grekas
Copy link
Member

Could you please add a line about it in the changelog of the component?

@fre5h
Copy link
ContributorAuthor

@nicolas-grekas Added

@nicolas-grekas
Copy link
Member

Thank you@fre5h.

nicolas-grekas added a commit that referenced this pull requestDec 26, 2019
…Email and Tel form types (fre5h)This PR was squashed before being merged into the 5.1-dev branch.Discussion----------[Form] Added default `inputmode` attribute to Search, Email and Tel form types| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | no| License       | MIT| Doc PR        | noThere is an HTML5 attribute `inputmode`. Seehttps://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/inputmode It is supported by most of mobile browsers.There are such supported values for `inputmode`:* `none`* `text` (default value)* `decimal`* `numeric `* `tel`* `search`* `email`* `url`The `url` inputmode is already implemented in UrlTypehttps://github.com/symfony/symfony/blob/master/src/Symfony/Component/Form/Extension/Core/Type/UrlType.php#L39I propose to add `tel`, `search`, `email` as default form view attribute to the relevant form types. Why only these three? `url` is already implemented, `none` makes no sense as default value for any form type, `text` is a default input type for any browser.`decimal` and `numeric` has different behaviour on iOS. iOS doesn't show `-` (minus) sign on keyboard for these input modes. Of course in cases, when only positive numbers are expected, it is normal. But it is not suitable as default value in Symfony form type. Developers can add this attribute manually in their forms, if they need only positive numbers.But `search`, `tel` and `email` input modes don't have problems and can be added as default attributes to Symfony form types. This will improve user experience, while using web-sites developed on Symfony on mobile devices. I add it into the *Type classes inside `buildView` method, so it will be possible to override this parameter if needed.If you are interested in how it looks like in mobile browsers, you can open this linkhttps://inputmodes.com/ on you mobile device.Here are screenshots, how mobile keyboard looks like on Android and iOS with using `inputmode` attribute.## `tel` inputmode![image](https://user-images.githubusercontent.com/815865/70866507-45256480-1f73-11ea-9e82-320ef0b978ab.png)## `email` inputmode![image](https://user-images.githubusercontent.com/815865/70866502-3a6acf80-1f73-11ea-8f4c-3e7faca47f54.png)## `search` inputmode![image](https://user-images.githubusercontent.com/815865/70866498-2cb54a00-1f73-11ea-9fdc-2bb8abed107d.png)Commits-------dbc500f [Form] Added default `inputmode` attribute to Search, Email and Tel form types
@nicolas-grekasnicolas-grekas merged commitdbc500f intosymfony:masterDec 26, 2019
@fre5hfre5h deleted the feature-inputmode branchDecember 26, 2019 09:34
@stfalcon
Copy link
Contributor

Nice job!@fre5h

@staabmstaabm mentioned this pull requestDec 29, 2019
5 tasks
@nicolas-grekasnicolas-grekas modified the milestones:next,5.1May 4, 2020
@fabpotfabpot mentioned this pull requestMay 5, 2020
@MatTheCat
Copy link
Contributor

MatTheCat commentedMay 19, 2020•
edited
Loading

inputmode was specified inUrlType when thetype cannot beurl because of thedefault_protocol option. Is there any need to add it when it should be inferred from the inputtype?

Fromhttps://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/inputmode

tel
Inputs thatrequire a telephone number should typically use<input type="tel"> instead.

search
Inputs thatrequire a search query should typically use<input type="search"> instead.

email
Inputs thatrequire email addresses should typically use<input type="email"> instead.

@xabbuh
Copy link
Member

@MatTheCat I am afraid I do not understand your question.

@MatTheCat
Copy link
Contributor

inputmode seems to be useless when it can be inferred from thetype attribute, which is the case fortel,search andemail. So what is the point to add it on these?

@xabbuh
Copy link
Member

If I don't miss anything, we don't make use of these specialisedtype attributes yet.

@MatTheCat
Copy link
Contributor

MatTheCat commentedMay 19, 2020•
edited
Loading

Fortunately, we do:

{%-blockemail_widget -%}
{%-settype=type|default('email') -%}
{{block('form_widget_simple') }}
{%-endblockemail_widget -%}

{%-blocktel_widget -%}
{%-settype=type|default('tel') -%}
{{block('form_widget_simple') }}
{%-endblocktel_widget -%}

{%-blocksearch_widget -%}
{%-settype=type|default('search') -%}
{{block('form_widget_simple') }}
{%-endblocksearch_widget -%}

fabpot added a commit that referenced this pull requestMay 22, 2020
…ype is the same (MatTheCat)This PR was submitted for the master branch but it was merged into the 5.1 branch instead.Discussion----------[Form] don't add the inputmode attribute on fields whose type is the same| Q             | A| ------------- | ---| Branch?       | 5.1| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       |Fix#34986| License       | MITThese is no need to add the `inputmode` attribute on fields whose `type` is the same.Fromhttps://html.spec.whatwg.org/multipage/interaction.html#attr-inputmode> When inputmode is unspecified (or is in a state not supported by the user agent), the user agent should determine the default virtual keyboard to be shown. Contextual information such as the input type or pattern attributes should be used to determine which type of virtual keyboard should be presented to the user.Fromhttps://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/inputmode> **tel**> Inputs that *require* a telephone number should typically use `<input type="tel">` instead.> **search**> Inputs that *require* a search query should typically use `<input type="search">` instead.> **email**> Inputs that *require* email addresses should typically use `<input type="email">` instead.As such there is no point in adding `inputmode` for those types.Symfony’s `UrlType` uses `inputmode` **only** when the `type` has to be `text` because the `default_protocol` option is set.Commits-------d933fa1 Revert#34986
symfony-splitter pushed a commit to symfony/form that referenced this pull requestMay 22, 2020
nicolas-grekas added a commit that referenced this pull requestMay 23, 2020
* 5.1: (33 commits)  [Cache] $lifetime cannot be null  [Serializer] minor cleanup  fix merge  Run PHP 8 as 7.4.99  Remove calls to deprecated ReflectionParameter::getClass().  [VarDumper] fix PHP 8 support  Removed "services" prototype node from "custom_authenticator"  Add php 8 to travis.  [Cache] Accessing undefined constants raises an Error in php8  [Cache] allow DBAL v3  Skip Doctrine DBAL on php 8 until we have a compatible version.  [DomCrawler] Catch expected ValueError.  Made method signatures compatible with their corresponding traits.  [ErrorHandler] Apply php8 fixes from Debug component.  [DomCrawler] Catch expected ValueError.  [Validator] Catch expected ValueError.  [VarDumper] ReflectionFunction::isDisabled() is deprecated.  [BrowserKit] Raw body with custom Content-Type header  Revert#34986  Make ExpressionLanguageSyntax validator usable with annotation  ...
symfony-splitter pushed a commit to symfony/dom-crawler that referenced this pull requestMay 23, 2020
* 5.1: (33 commits)  [Cache] $lifetime cannot be null  [Serializer] minor cleanup  fix merge  Run PHP 8 as 7.4.99  Remove calls to deprecated ReflectionParameter::getClass().  [VarDumper] fix PHP 8 support  Removed "services" prototype node from "custom_authenticator"  Add php 8 to travis.  [Cache] Accessing undefined constants raises an Error in php8  [Cache] allow DBAL v3  Skip Doctrine DBAL on php 8 until we have a compatible version.  [DomCrawler] Catch expected ValueError.  Made method signatures compatible with their corresponding traits.  [ErrorHandler] Apply php8 fixes from Debug component.  [DomCrawler] Catch expected ValueError.  [Validator] Catch expected ValueError.  [VarDumper] ReflectionFunction::isDisabled() is deprecated.  [BrowserKit] Raw body with custom Content-Type header  Revertsymfony/symfony#34986  Make ExpressionLanguageSyntax validator usable with annotation  ...
symfony-splitter pushed a commit to symfony/http-foundation that referenced this pull requestMay 23, 2020
* 5.1: (33 commits)  [Cache] $lifetime cannot be null  [Serializer] minor cleanup  fix merge  Run PHP 8 as 7.4.99  Remove calls to deprecated ReflectionParameter::getClass().  [VarDumper] fix PHP 8 support  Removed "services" prototype node from "custom_authenticator"  Add php 8 to travis.  [Cache] Accessing undefined constants raises an Error in php8  [Cache] allow DBAL v3  Skip Doctrine DBAL on php 8 until we have a compatible version.  [DomCrawler] Catch expected ValueError.  Made method signatures compatible with their corresponding traits.  [ErrorHandler] Apply php8 fixes from Debug component.  [DomCrawler] Catch expected ValueError.  [Validator] Catch expected ValueError.  [VarDumper] ReflectionFunction::isDisabled() is deprecated.  [BrowserKit] Raw body with custom Content-Type header  Revertsymfony/symfony#34986  Make ExpressionLanguageSyntax validator usable with annotation  ...
symfony-splitter pushed a commit to symfony/serializer that referenced this pull requestMay 23, 2020
* 5.1: (33 commits)  [Cache] $lifetime cannot be null  [Serializer] minor cleanup  fix merge  Run PHP 8 as 7.4.99  Remove calls to deprecated ReflectionParameter::getClass().  [VarDumper] fix PHP 8 support  Removed "services" prototype node from "custom_authenticator"  Add php 8 to travis.  [Cache] Accessing undefined constants raises an Error in php8  [Cache] allow DBAL v3  Skip Doctrine DBAL on php 8 until we have a compatible version.  [DomCrawler] Catch expected ValueError.  Made method signatures compatible with their corresponding traits.  [ErrorHandler] Apply php8 fixes from Debug component.  [DomCrawler] Catch expected ValueError.  [Validator] Catch expected ValueError.  [VarDumper] ReflectionFunction::isDisabled() is deprecated.  [BrowserKit] Raw body with custom Content-Type header  Revertsymfony/symfony#34986  Make ExpressionLanguageSyntax validator usable with annotation  ...
symfony-splitter pushed a commit to symfony/var-dumper that referenced this pull requestMay 23, 2020
* 5.1: (33 commits)  [Cache] $lifetime cannot be null  [Serializer] minor cleanup  fix merge  Run PHP 8 as 7.4.99  Remove calls to deprecated ReflectionParameter::getClass().  [VarDumper] fix PHP 8 support  Removed "services" prototype node from "custom_authenticator"  Add php 8 to travis.  [Cache] Accessing undefined constants raises an Error in php8  [Cache] allow DBAL v3  Skip Doctrine DBAL on php 8 until we have a compatible version.  [DomCrawler] Catch expected ValueError.  Made method signatures compatible with their corresponding traits.  [ErrorHandler] Apply php8 fixes from Debug component.  [DomCrawler] Catch expected ValueError.  [Validator] Catch expected ValueError.  [VarDumper] ReflectionFunction::isDisabled() is deprecated.  [BrowserKit] Raw body with custom Content-Type header  Revertsymfony/symfony#34986  Make ExpressionLanguageSyntax validator usable with annotation  ...
symfony-splitter pushed a commit to symfony/security-bundle that referenced this pull requestMay 23, 2020
* 5.1: (33 commits)  [Cache] $lifetime cannot be null  [Serializer] minor cleanup  fix merge  Run PHP 8 as 7.4.99  Remove calls to deprecated ReflectionParameter::getClass().  [VarDumper] fix PHP 8 support  Removed "services" prototype node from "custom_authenticator"  Add php 8 to travis.  [Cache] Accessing undefined constants raises an Error in php8  [Cache] allow DBAL v3  Skip Doctrine DBAL on php 8 until we have a compatible version.  [DomCrawler] Catch expected ValueError.  Made method signatures compatible with their corresponding traits.  [ErrorHandler] Apply php8 fixes from Debug component.  [DomCrawler] Catch expected ValueError.  [Validator] Catch expected ValueError.  [VarDumper] ReflectionFunction::isDisabled() is deprecated.  [BrowserKit] Raw body with custom Content-Type header  Revertsymfony/symfony#34986  Make ExpressionLanguageSyntax validator usable with annotation  ...
symfony-splitter pushed a commit to symfony/phpunit-bridge that referenced this pull requestMay 23, 2020
* 5.1: (33 commits)  [Cache] $lifetime cannot be null  [Serializer] minor cleanup  fix merge  Run PHP 8 as 7.4.99  Remove calls to deprecated ReflectionParameter::getClass().  [VarDumper] fix PHP 8 support  Removed "services" prototype node from "custom_authenticator"  Add php 8 to travis.  [Cache] Accessing undefined constants raises an Error in php8  [Cache] allow DBAL v3  Skip Doctrine DBAL on php 8 until we have a compatible version.  [DomCrawler] Catch expected ValueError.  Made method signatures compatible with their corresponding traits.  [ErrorHandler] Apply php8 fixes from Debug component.  [DomCrawler] Catch expected ValueError.  [Validator] Catch expected ValueError.  [VarDumper] ReflectionFunction::isDisabled() is deprecated.  [BrowserKit] Raw body with custom Content-Type header  Revertsymfony/symfony#34986  Make ExpressionLanguageSyntax validator usable with annotation  ...
symfony-splitter pushed a commit to symfony/config that referenced this pull requestMay 23, 2020
* 5.1: (33 commits)  [Cache] $lifetime cannot be null  [Serializer] minor cleanup  fix merge  Run PHP 8 as 7.4.99  Remove calls to deprecated ReflectionParameter::getClass().  [VarDumper] fix PHP 8 support  Removed "services" prototype node from "custom_authenticator"  Add php 8 to travis.  [Cache] Accessing undefined constants raises an Error in php8  [Cache] allow DBAL v3  Skip Doctrine DBAL on php 8 until we have a compatible version.  [DomCrawler] Catch expected ValueError.  Made method signatures compatible with their corresponding traits.  [ErrorHandler] Apply php8 fixes from Debug component.  [DomCrawler] Catch expected ValueError.  [Validator] Catch expected ValueError.  [VarDumper] ReflectionFunction::isDisabled() is deprecated.  [BrowserKit] Raw body with custom Content-Type header  Revertsymfony/symfony#34986  Make ExpressionLanguageSyntax validator usable with annotation  ...
symfony-splitter pushed a commit to symfony/security-core that referenced this pull requestMay 23, 2020
* 5.1: (33 commits)  [Cache] $lifetime cannot be null  [Serializer] minor cleanup  fix merge  Run PHP 8 as 7.4.99  Remove calls to deprecated ReflectionParameter::getClass().  [VarDumper] fix PHP 8 support  Removed "services" prototype node from "custom_authenticator"  Add php 8 to travis.  [Cache] Accessing undefined constants raises an Error in php8  [Cache] allow DBAL v3  Skip Doctrine DBAL on php 8 until we have a compatible version.  [DomCrawler] Catch expected ValueError.  Made method signatures compatible with their corresponding traits.  [ErrorHandler] Apply php8 fixes from Debug component.  [DomCrawler] Catch expected ValueError.  [Validator] Catch expected ValueError.  [VarDumper] ReflectionFunction::isDisabled() is deprecated.  [BrowserKit] Raw body with custom Content-Type header  Revertsymfony/symfony#34986  Make ExpressionLanguageSyntax validator usable with annotation  ...
symfony-splitter pushed a commit to symfony/browser-kit that referenced this pull requestMay 23, 2020
* 5.1: (33 commits)  [Cache] $lifetime cannot be null  [Serializer] minor cleanup  fix merge  Run PHP 8 as 7.4.99  Remove calls to deprecated ReflectionParameter::getClass().  [VarDumper] fix PHP 8 support  Removed "services" prototype node from "custom_authenticator"  Add php 8 to travis.  [Cache] Accessing undefined constants raises an Error in php8  [Cache] allow DBAL v3  Skip Doctrine DBAL on php 8 until we have a compatible version.  [DomCrawler] Catch expected ValueError.  Made method signatures compatible with their corresponding traits.  [ErrorHandler] Apply php8 fixes from Debug component.  [DomCrawler] Catch expected ValueError.  [Validator] Catch expected ValueError.  [VarDumper] ReflectionFunction::isDisabled() is deprecated.  [BrowserKit] Raw body with custom Content-Type header  Revertsymfony/symfony#34986  Make ExpressionLanguageSyntax validator usable with annotation  ...
symfony-splitter pushed a commit to symfony/form that referenced this pull requestMay 23, 2020
* 5.1: (33 commits)  [Cache] $lifetime cannot be null  [Serializer] minor cleanup  fix merge  Run PHP 8 as 7.4.99  Remove calls to deprecated ReflectionParameter::getClass().  [VarDumper] fix PHP 8 support  Removed "services" prototype node from "custom_authenticator"  Add php 8 to travis.  [Cache] Accessing undefined constants raises an Error in php8  [Cache] allow DBAL v3  Skip Doctrine DBAL on php 8 until we have a compatible version.  [DomCrawler] Catch expected ValueError.  Made method signatures compatible with their corresponding traits.  [ErrorHandler] Apply php8 fixes from Debug component.  [DomCrawler] Catch expected ValueError.  [Validator] Catch expected ValueError.  [VarDumper] ReflectionFunction::isDisabled() is deprecated.  [BrowserKit] Raw body with custom Content-Type header  Revertsymfony/symfony#34986  Make ExpressionLanguageSyntax validator usable with annotation  ...
symfony-splitter pushed a commit to symfony/amazon-sqs-messenger that referenced this pull requestMay 23, 2020
* 5.1: (33 commits)  [Cache] $lifetime cannot be null  [Serializer] minor cleanup  fix merge  Run PHP 8 as 7.4.99  Remove calls to deprecated ReflectionParameter::getClass().  [VarDumper] fix PHP 8 support  Removed "services" prototype node from "custom_authenticator"  Add php 8 to travis.  [Cache] Accessing undefined constants raises an Error in php8  [Cache] allow DBAL v3  Skip Doctrine DBAL on php 8 until we have a compatible version.  [DomCrawler] Catch expected ValueError.  Made method signatures compatible with their corresponding traits.  [ErrorHandler] Apply php8 fixes from Debug component.  [DomCrawler] Catch expected ValueError.  [Validator] Catch expected ValueError.  [VarDumper] ReflectionFunction::isDisabled() is deprecated.  [BrowserKit] Raw body with custom Content-Type header  Revertsymfony/symfony#34986  Make ExpressionLanguageSyntax validator usable with annotation  ...
symfony-splitter pushed a commit to symfony/doctrine-messenger that referenced this pull requestMay 23, 2020
* 5.1: (33 commits)  [Cache] $lifetime cannot be null  [Serializer] minor cleanup  fix merge  Run PHP 8 as 7.4.99  Remove calls to deprecated ReflectionParameter::getClass().  [VarDumper] fix PHP 8 support  Removed "services" prototype node from "custom_authenticator"  Add php 8 to travis.  [Cache] Accessing undefined constants raises an Error in php8  [Cache] allow DBAL v3  Skip Doctrine DBAL on php 8 until we have a compatible version.  [DomCrawler] Catch expected ValueError.  Made method signatures compatible with their corresponding traits.  [ErrorHandler] Apply php8 fixes from Debug component.  [DomCrawler] Catch expected ValueError.  [Validator] Catch expected ValueError.  [VarDumper] ReflectionFunction::isDisabled() is deprecated.  [BrowserKit] Raw body with custom Content-Type header  Revertsymfony/symfony#34986  Make ExpressionLanguageSyntax validator usable with annotation  ...
symfony-splitter pushed a commit to symfony/cache that referenced this pull requestMay 23, 2020
* 5.1: (33 commits)  [Cache] $lifetime cannot be null  [Serializer] minor cleanup  fix merge  Run PHP 8 as 7.4.99  Remove calls to deprecated ReflectionParameter::getClass().  [VarDumper] fix PHP 8 support  Removed "services" prototype node from "custom_authenticator"  Add php 8 to travis.  [Cache] Accessing undefined constants raises an Error in php8  [Cache] allow DBAL v3  Skip Doctrine DBAL on php 8 until we have a compatible version.  [DomCrawler] Catch expected ValueError.  Made method signatures compatible with their corresponding traits.  [ErrorHandler] Apply php8 fixes from Debug component.  [DomCrawler] Catch expected ValueError.  [Validator] Catch expected ValueError.  [VarDumper] ReflectionFunction::isDisabled() is deprecated.  [BrowserKit] Raw body with custom Content-Type header  Revertsymfony/symfony#34986  Make ExpressionLanguageSyntax validator usable with annotation  ...
symfony-splitter pushed a commit to symfony/options-resolver that referenced this pull requestMay 23, 2020
* 5.1: (33 commits)  [Cache] $lifetime cannot be null  [Serializer] minor cleanup  fix merge  Run PHP 8 as 7.4.99  Remove calls to deprecated ReflectionParameter::getClass().  [VarDumper] fix PHP 8 support  Removed "services" prototype node from "custom_authenticator"  Add php 8 to travis.  [Cache] Accessing undefined constants raises an Error in php8  [Cache] allow DBAL v3  Skip Doctrine DBAL on php 8 until we have a compatible version.  [DomCrawler] Catch expected ValueError.  Made method signatures compatible with their corresponding traits.  [ErrorHandler] Apply php8 fixes from Debug component.  [DomCrawler] Catch expected ValueError.  [Validator] Catch expected ValueError.  [VarDumper] ReflectionFunction::isDisabled() is deprecated.  [BrowserKit] Raw body with custom Content-Type header  Revertsymfony/symfony#34986  Make ExpressionLanguageSyntax validator usable with annotation  ...
symfony-splitter pushed a commit to symfony/intl that referenced this pull requestMay 23, 2020
* 5.1: (33 commits)  [Cache] $lifetime cannot be null  [Serializer] minor cleanup  fix merge  Run PHP 8 as 7.4.99  Remove calls to deprecated ReflectionParameter::getClass().  [VarDumper] fix PHP 8 support  Removed "services" prototype node from "custom_authenticator"  Add php 8 to travis.  [Cache] Accessing undefined constants raises an Error in php8  [Cache] allow DBAL v3  Skip Doctrine DBAL on php 8 until we have a compatible version.  [DomCrawler] Catch expected ValueError.  Made method signatures compatible with their corresponding traits.  [ErrorHandler] Apply php8 fixes from Debug component.  [DomCrawler] Catch expected ValueError.  [Validator] Catch expected ValueError.  [VarDumper] ReflectionFunction::isDisabled() is deprecated.  [BrowserKit] Raw body with custom Content-Type header  Revertsymfony/symfony#34986  Make ExpressionLanguageSyntax validator usable with annotation  ...
symfony-splitter pushed a commit to symfony/messenger that referenced this pull requestMay 23, 2020
* 5.1: (33 commits)  [Cache] $lifetime cannot be null  [Serializer] minor cleanup  fix merge  Run PHP 8 as 7.4.99  Remove calls to deprecated ReflectionParameter::getClass().  [VarDumper] fix PHP 8 support  Removed "services" prototype node from "custom_authenticator"  Add php 8 to travis.  [Cache] Accessing undefined constants raises an Error in php8  [Cache] allow DBAL v3  Skip Doctrine DBAL on php 8 until we have a compatible version.  [DomCrawler] Catch expected ValueError.  Made method signatures compatible with their corresponding traits.  [ErrorHandler] Apply php8 fixes from Debug component.  [DomCrawler] Catch expected ValueError.  [Validator] Catch expected ValueError.  [VarDumper] ReflectionFunction::isDisabled() is deprecated.  [BrowserKit] Raw body with custom Content-Type header  Revertsymfony/symfony#34986  Make ExpressionLanguageSyntax validator usable with annotation  ...
symfony-splitter pushed a commit to symfony/validator that referenced this pull requestMay 23, 2020
* 5.1: (33 commits)  [Cache] $lifetime cannot be null  [Serializer] minor cleanup  fix merge  Run PHP 8 as 7.4.99  Remove calls to deprecated ReflectionParameter::getClass().  [VarDumper] fix PHP 8 support  Removed "services" prototype node from "custom_authenticator"  Add php 8 to travis.  [Cache] Accessing undefined constants raises an Error in php8  [Cache] allow DBAL v3  Skip Doctrine DBAL on php 8 until we have a compatible version.  [DomCrawler] Catch expected ValueError.  Made method signatures compatible with their corresponding traits.  [ErrorHandler] Apply php8 fixes from Debug component.  [DomCrawler] Catch expected ValueError.  [Validator] Catch expected ValueError.  [VarDumper] ReflectionFunction::isDisabled() is deprecated.  [BrowserKit] Raw body with custom Content-Type header  Revertsymfony/symfony#34986  Make ExpressionLanguageSyntax validator usable with annotation  ...
symfony-splitter pushed a commit to symfony/error-handler that referenced this pull requestMay 23, 2020
* 5.1: (33 commits)  [Cache] $lifetime cannot be null  [Serializer] minor cleanup  fix merge  Run PHP 8 as 7.4.99  Remove calls to deprecated ReflectionParameter::getClass().  [VarDumper] fix PHP 8 support  Removed "services" prototype node from "custom_authenticator"  Add php 8 to travis.  [Cache] Accessing undefined constants raises an Error in php8  [Cache] allow DBAL v3  Skip Doctrine DBAL on php 8 until we have a compatible version.  [DomCrawler] Catch expected ValueError.  Made method signatures compatible with their corresponding traits.  [ErrorHandler] Apply php8 fixes from Debug component.  [DomCrawler] Catch expected ValueError.  [Validator] Catch expected ValueError.  [VarDumper] ReflectionFunction::isDisabled() is deprecated.  [BrowserKit] Raw body with custom Content-Type header  Revertsymfony/symfony#34986  Make ExpressionLanguageSyntax validator usable with annotation  ...
symfony-splitter pushed a commit to symfony/property-access that referenced this pull requestMay 23, 2020
* 5.1: (33 commits)  [Cache] $lifetime cannot be null  [Serializer] minor cleanup  fix merge  Run PHP 8 as 7.4.99  Remove calls to deprecated ReflectionParameter::getClass().  [VarDumper] fix PHP 8 support  Removed "services" prototype node from "custom_authenticator"  Add php 8 to travis.  [Cache] Accessing undefined constants raises an Error in php8  [Cache] allow DBAL v3  Skip Doctrine DBAL on php 8 until we have a compatible version.  [DomCrawler] Catch expected ValueError.  Made method signatures compatible with their corresponding traits.  [ErrorHandler] Apply php8 fixes from Debug component.  [DomCrawler] Catch expected ValueError.  [Validator] Catch expected ValueError.  [VarDumper] ReflectionFunction::isDisabled() is deprecated.  [BrowserKit] Raw body with custom Content-Type header  Revertsymfony/symfony#34986  Make ExpressionLanguageSyntax validator usable with annotation  ...
symfony-splitter pushed a commit to symfony/doctrine-bridge that referenced this pull requestMay 23, 2020
* 5.1: (33 commits)  [Cache] $lifetime cannot be null  [Serializer] minor cleanup  fix merge  Run PHP 8 as 7.4.99  Remove calls to deprecated ReflectionParameter::getClass().  [VarDumper] fix PHP 8 support  Removed "services" prototype node from "custom_authenticator"  Add php 8 to travis.  [Cache] Accessing undefined constants raises an Error in php8  [Cache] allow DBAL v3  Skip Doctrine DBAL on php 8 until we have a compatible version.  [DomCrawler] Catch expected ValueError.  Made method signatures compatible with their corresponding traits.  [ErrorHandler] Apply php8 fixes from Debug component.  [DomCrawler] Catch expected ValueError.  [Validator] Catch expected ValueError.  [VarDumper] ReflectionFunction::isDisabled() is deprecated.  [BrowserKit] Raw body with custom Content-Type header  Revertsymfony/symfony#34986  Make ExpressionLanguageSyntax validator usable with annotation  ...
symfony-splitter pushed a commit to symfony/http-client that referenced this pull requestMay 23, 2020
* 5.1: (33 commits)  [Cache] $lifetime cannot be null  [Serializer] minor cleanup  fix merge  Run PHP 8 as 7.4.99  Remove calls to deprecated ReflectionParameter::getClass().  [VarDumper] fix PHP 8 support  Removed "services" prototype node from "custom_authenticator"  Add php 8 to travis.  [Cache] Accessing undefined constants raises an Error in php8  [Cache] allow DBAL v3  Skip Doctrine DBAL on php 8 until we have a compatible version.  [DomCrawler] Catch expected ValueError.  Made method signatures compatible with their corresponding traits.  [ErrorHandler] Apply php8 fixes from Debug component.  [DomCrawler] Catch expected ValueError.  [Validator] Catch expected ValueError.  [VarDumper] ReflectionFunction::isDisabled() is deprecated.  [BrowserKit] Raw body with custom Content-Type header  Revertsymfony/symfony#34986  Make ExpressionLanguageSyntax validator usable with annotation  ...
symfony-splitter pushed a commit to symfony/messenger that referenced this pull requestSep 28, 2021
* 5.1: (33 commits)  [Cache] $lifetime cannot be null  [Serializer] minor cleanup  fix merge  Run PHP 8 as 7.4.99  Remove calls to deprecated ReflectionParameter::getClass().  [VarDumper] fix PHP 8 support  Removed "services" prototype node from "custom_authenticator"  Add php 8 to travis.  [Cache] Accessing undefined constants raises an Error in php8  [Cache] allow DBAL v3  Skip Doctrine DBAL on php 8 until we have a compatible version.  [DomCrawler] Catch expected ValueError.  Made method signatures compatible with their corresponding traits.  [ErrorHandler] Apply php8 fixes from Debug component.  [DomCrawler] Catch expected ValueError.  [Validator] Catch expected ValueError.  [VarDumper] ReflectionFunction::isDisabled() is deprecated.  [BrowserKit] Raw body with custom Content-Type header  Revertsymfony/symfony#34986  Make ExpressionLanguageSyntax validator usable with annotation  ...
sadafrangian3 pushed a commit to sadafrangian3/Dependency-Injection-http-client that referenced this pull requestNov 2, 2022
* 5.1: (33 commits)  [Cache] $lifetime cannot be null  [Serializer] minor cleanup  fix merge  Run PHP 8 as 7.4.99  Remove calls to deprecated ReflectionParameter::getClass().  [VarDumper] fix PHP 8 support  Removed "services" prototype node from "custom_authenticator"  Add php 8 to travis.  [Cache] Accessing undefined constants raises an Error in php8  [Cache] allow DBAL v3  Skip Doctrine DBAL on php 8 until we have a compatible version.  [DomCrawler] Catch expected ValueError.  Made method signatures compatible with their corresponding traits.  [ErrorHandler] Apply php8 fixes from Debug component.  [DomCrawler] Catch expected ValueError.  [Validator] Catch expected ValueError.  [VarDumper] ReflectionFunction::isDisabled() is deprecated.  [BrowserKit] Raw body with custom Content-Type header  Revertsymfony/symfony#34986  Make ExpressionLanguageSyntax validator usable with annotation  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@xabbuhxabbuhxabbuh approved these changes

@ycerutoycerutoyceruto approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

8 participants
@fre5h@nicolas-grekas@stfalcon@MatTheCat@xabbuh@javiereguiluz@yceruto@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp