Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Security] Revert "AbstractAuthenticationListener.php error instead info"#34957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
weaverryan left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Because the new error() level has a very practical negative effect (all login attempts are going into high priority log handlers, commonly Slack) and there is no easy way to work around this (that I know of), I think we should merge this and revisit how this could be done in a more flexible way. I get why it was done, but our logs are going crazy :)
Note: should be merged into 4.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Works for me, for 4.4
…nfo. Rebase ofsymfony#28462"This reverts commit867eb78.
Thank you @larzuk91. |
…r instead info" (larzuk91)This PR was submitted for the master branch but it was merged into the 4.4 branch instead.Discussion----------[Security] Revert "AbstractAuthenticationListener.php error instead info"| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |Fix#34836| License | MITThis reverts commit867eb78.After that change, every failed login attempt is logged as an error. It's flooding our errors log channelCommits-------9d306f9 [SECURITY] Revert "AbstractAuthenticationListener.php error instead info. Rebase of#28462"
This reverts commit867eb78.
After that change, every failed login attempt is logged as an error. It's flooding our errors log channel