Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[ErrorHandler] Enabled the dark theme for exception pages#34924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
🚀 🚢 💯 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Beautiful :)
Thank you@javiereguiluz. |
…ges (javiereguiluz)This PR was merged into the 5.1-dev branch.Discussion----------[ErrorHandler] Enabled the dark theme for exception pages| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -This makes the exception pages compatible with the dark theme. By default, they use the same setting as the Profiler. If no setting is defined, it auto-selects the theme based on the operating system theme.Some comparison screenshots:Commits-------24f32f8 [ErrorHandler] Enabled the dark theme for exception pages
| @@ -66,7 +66,7 @@ | |||
| --metric-unit-color: #999; | |||
| --metric-label-background: #777; | |||
| --metric-label-color: #e0e0e0; | |||
| --trace-selected-background: #71663a; | |||
| --trace-selected-background: #71663acc; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The#RRGGBBAA notation for colors is not supported by Edge. I suggest using thergba() notation instead.
| --metric-unit-color: #999; | ||
| --metric-label-background: #777; | ||
| --metric-label-color: #e0e0e0; | ||
| --trace-selected-background: #71663acc; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
same here
This makes the exception pages compatible with the dark theme. By default, they use the same setting as the Profiler. If no setting is defined, it auto-selects the theme based on the operating system theme.
Some comparison screenshots: