Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[DI] Fix support for immutable setters in CallTrait#34923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Lctrs commentedDec 10, 2019
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR | N/A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For 4.4 as a bug fix to me.
Not in |
4.3 then, you're right! |
@nicolas-grekas Done ! |
| * | ||
| * @return $this | ||
| * | ||
| * @throws InvalidArgumentException on empty $method param | ||
| */ | ||
| final public function call($method, array $arguments = []) | ||
| final public function call($method, array $arguments = []/*, bool $returnsClone = false*/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No need for the compat layer: the method is final, wecan add the argument.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done.
Thank you@Lctrs. |
This PR was merged into the 4.3 branch.Discussion----------[DI] Fix support for immutable setters in CallTrait| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets || License | MIT| Doc PR | N/ACommits-------90ace51 [DI] Add support for immutable setters in CallTrait