Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle] Allow using a ContainerConfigurator in MicroKernelTrait::configureContainer()#34873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

The head ref may contain hidden characters:"\u00B5kconfigurator"

Dismiss

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekasnicolas-grekas commentedDec 7, 2019
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

This PR is a continuation of#32937 (it reverts some parts of it that are not needed anymore). It builds on#34872 for now.

This PR allows using the PHP-DSL natively in ourKernel::configureContainer() methods.
It allows the same in ourKernel::configureRoutes() methods.

Both signatures are handled gracefully with no deprecations to let existing code in peace:

  • protected function configureContainer(ContainerBuilder $c, LoaderInterface $loader);
  • protected function configureContainer(ContainerConfigurator $c); (a loader is always passed as 2nd arg to ease FC)

Same for routes:

  • protected function configureRoutes(RoutingConfigurator $routes);
  • protected function configureRoutes(RouteCollectionBuilder $routes); (this one is deprecated becauseRouteCollectionBuilder is deprecated)

Here is my workingsrc/Kernel.php after this change:

class Kernelextends BaseKernel{use MicroKernelTrait;protectedfunctionconfigureContainer(ContainerConfigurator$container):void    {$container->import('../config/{packages}/*.yaml');$container->import('../config/{packages}/'.$this->environment.'/*.yaml');$container->import('../config/services.yaml');$container->import('../config/{services}_'.$this->environment.'.yaml');    }protectedfunctionconfigureRoutes(RoutingConfigurator$routes):void    {$routes->import('../config/{routes}/'.$this->environment.'/*.yaml');$routes->import('../config/{routes}/*.yaml');$routes->import('../config/routes.yaml');    }}

ihmels, bonfante, vudaltsov, and TomasVotruba reacted with thumbs up emojiKoc, timglabisch, and vudaltsov reacted with rocket emoji
Copy link
Contributor

@vudaltsovvudaltsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is a great alternative to my deprecations! Learned a lot, thanx!

@nicolas-grekasnicolas-grekasforce-pushed theµkconfigurator branch 2 times, most recently from0334df3 to0069b92CompareDecember 11, 2019 10:47
nicolas-grekas added a commit that referenced this pull requestDec 13, 2019
…in MicroKernelTrait::configureContainer() (nicolas-grekas)This PR was merged into the 5.1-dev branch.Discussion----------[FrameworkBundle] Allow using a ContainerConfigurator in MicroKernelTrait::configureContainer()| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -This PR is a continuation of#32937 (it reverts some parts of it that are not needed anymore). It builds on#34872 for now.This PR allows using the PHP-DSL natively in our `Kernel::configureContainer()` methods.It allows the same in our `Kernel::configureRoutes()` methods.Both signatures are handled gracefully with no deprecations to let existing code in peace:- `protected function configureContainer(ContainerBuilder $c, LoaderInterface $loader);`- `protected function configureContainer(ContainerConfigurator $c);` (a loader is always passed as 2nd arg to ease FC)Same for routes:- `protected function configureRoutes(RoutingConfigurator $routes);`- `protected function configureRoutes(RouteCollectionBuilder $routes);` (this one is deprecated because `RouteCollectionBuilder` is deprecated)Here is my working `src/Kernel.php` after this change:```phpclass Kernel extends BaseKernel{    use MicroKernelTrait;    protected function configureContainer(ContainerConfigurator $container): void    {        $container->import('../config/{packages}/*.yaml');        $container->import('../config/{packages}/'.$this->environment.'/*.yaml');        $container->import('../config/services.yaml');        $container->import('../config/{services}_'.$this->environment.'.yaml');    }    protected function configureRoutes(RoutingConfigurator $routes): void    {        $routes->import('../config/{routes}/'.$this->environment.'/*.yaml');        $routes->import('../config/{routes}/*.yaml');        $routes->import('../config/routes.yaml');    }}```Commits-------cf45eec [FrameworkBundle] Allow using a ContainerConfigurator in MicroKernelTrait::configureContainer()
@nicolas-grekasnicolas-grekas merged commitcf45eec intosymfony:masterDec 13, 2019
@nicolas-grekasnicolas-grekas deleted the µkconfigurator branchDecember 13, 2019 13:12
nicolas-grekas added a commit that referenced this pull requestDec 17, 2019
… of controllers and service factories (nicolas-grekas)This PR was merged into the 5.1-dev branch.Discussion----------[FrameworkBundle] Allow using the kernel as a registry of controllers and service factories| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       |Fix#28992,fix#29997| License       | MIT| Doc PR        | -This PR builds on#34873 and#34872 and allows using the `Kernel` as a registry of autowired controllers and service factories. The `ContainerConfigurator` passed to `configureContainer()` defaults to declaring autowired and autoconfigured services.TL;DR: Silex is back but in a much more powerful way \o/Here is a Kernel that just works and displays `Hello App\Foo` on the `/` route:```phpclass Kernel extends BaseKernel{    use MicroKernelTrait;    protected function configureContainer(ContainerConfigurator $container): void    {        $container->services()            ->load('App\\', '../src')            ->set(Foo::class)                ->factory([$this, 'createFoo']);    }    public function createFoo(Bar $bar)    {        return new Foo($bar);    }    protected function configureRoutes(RoutingConfigurator $routes): void    {        $routes->add('home', '/')->controller([$this, 'helloAction']);    }    public function helloAction(Foo $foo)    {        return new Response('Hello '.get_class($foo));    }}```Commits-------9c9b99c [FrameworkBundle] Allow using the kernel as a registry of controllers and service factories
@nicolas-grekasnicolas-grekas modified the milestones:next,5.1May 4, 2020
@fabpotfabpot mentioned this pull requestMay 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@TaluuTaluuTaluu approved these changes

@vudaltsovvudaltsovvudaltsov approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

4 participants
@nicolas-grekas@Taluu@vudaltsov@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp