Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[FrameworkBundle] Allow using a ContainerConfigurator in MicroKernelTrait::configureContainer()#34873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
The head ref may contain hidden characters:"\u00B5kconfigurator"
Uh oh!
There was an error while loading.Please reload this page.
Conversation
f9d7a9c
tob690a6d
CompareUh oh!
There was an error while loading.Please reload this page.
d6e4d6d
toe3c9889
Comparee3c9889
tofb2c385
CompareUh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is a great alternative to my deprecations! Learned a lot, thanx!
0334df3
to0069b92
Compare…rait::configureContainer()
0069b92
tocf45eec
Compare…in MicroKernelTrait::configureContainer() (nicolas-grekas)This PR was merged into the 5.1-dev branch.Discussion----------[FrameworkBundle] Allow using a ContainerConfigurator in MicroKernelTrait::configureContainer()| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -This PR is a continuation of#32937 (it reverts some parts of it that are not needed anymore). It builds on#34872 for now.This PR allows using the PHP-DSL natively in our `Kernel::configureContainer()` methods.It allows the same in our `Kernel::configureRoutes()` methods.Both signatures are handled gracefully with no deprecations to let existing code in peace:- `protected function configureContainer(ContainerBuilder $c, LoaderInterface $loader);`- `protected function configureContainer(ContainerConfigurator $c);` (a loader is always passed as 2nd arg to ease FC)Same for routes:- `protected function configureRoutes(RoutingConfigurator $routes);`- `protected function configureRoutes(RouteCollectionBuilder $routes);` (this one is deprecated because `RouteCollectionBuilder` is deprecated)Here is my working `src/Kernel.php` after this change:```phpclass Kernel extends BaseKernel{ use MicroKernelTrait; protected function configureContainer(ContainerConfigurator $container): void { $container->import('../config/{packages}/*.yaml'); $container->import('../config/{packages}/'.$this->environment.'/*.yaml'); $container->import('../config/services.yaml'); $container->import('../config/{services}_'.$this->environment.'.yaml'); } protected function configureRoutes(RoutingConfigurator $routes): void { $routes->import('../config/{routes}/'.$this->environment.'/*.yaml'); $routes->import('../config/{routes}/*.yaml'); $routes->import('../config/routes.yaml'); }}```Commits-------cf45eec [FrameworkBundle] Allow using a ContainerConfigurator in MicroKernelTrait::configureContainer()
… of controllers and service factories (nicolas-grekas)This PR was merged into the 5.1-dev branch.Discussion----------[FrameworkBundle] Allow using the kernel as a registry of controllers and service factories| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets |Fix#28992,fix#29997| License | MIT| Doc PR | -This PR builds on#34873 and#34872 and allows using the `Kernel` as a registry of autowired controllers and service factories. The `ContainerConfigurator` passed to `configureContainer()` defaults to declaring autowired and autoconfigured services.TL;DR: Silex is back but in a much more powerful way \o/Here is a Kernel that just works and displays `Hello App\Foo` on the `/` route:```phpclass Kernel extends BaseKernel{ use MicroKernelTrait; protected function configureContainer(ContainerConfigurator $container): void { $container->services() ->load('App\\', '../src') ->set(Foo::class) ->factory([$this, 'createFoo']); } public function createFoo(Bar $bar) { return new Foo($bar); } protected function configureRoutes(RoutingConfigurator $routes): void { $routes->add('home', '/')->controller([$this, 'helloAction']); } public function helloAction(Foo $foo) { return new Response('Hello '.get_class($foo)); }}```Commits-------9c9b99c [FrameworkBundle] Allow using the kernel as a registry of controllers and service factories
Uh oh!
There was an error while loading.Please reload this page.
This PR is a continuation of#32937 (it reverts some parts of it that are not needed anymore). It builds on#34872 for now.
This PR allows using the PHP-DSL natively in our
Kernel::configureContainer()
methods.It allows the same in our
Kernel::configureRoutes()
methods.Both signatures are handled gracefully with no deprecations to let existing code in peace:
protected function configureContainer(ContainerBuilder $c, LoaderInterface $loader);
protected function configureContainer(ContainerConfigurator $c);
(a loader is always passed as 2nd arg to ease FC)Same for routes:
protected function configureRoutes(RoutingConfigurator $routes);
protected function configureRoutes(RouteCollectionBuilder $routes);
(this one is deprecated becauseRouteCollectionBuilder
is deprecated)Here is my working
src/Kernel.php
after this change: