Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Added flex-compatible default implementations forMicroKernelTrait::registerBundles() andgetProjectDir()#34872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
The head ref may contain hidden characters:"\u00B5k"
Uh oh!
There was an error while loading.Please reload this page.
Conversation
MicroKernelTrait::registerBundles()ce63ec3 to3409955CompareMicroKernelTrait::registerBundles()MicroKernelTrait::registerBundles() andgetProjectDir()MicroKernelTrait::registerBundles() andgetProjectDir()MicroKernelTrait::registerBundles()5d7bd7b to09e198cCompareMicroKernelTrait::registerBundles()MicroKernelTrait::registerBundles() andgetProjectDir()| } | ||
| $container->fileExists($this->getProjectDir().'/config/bundles.php'); | ||
| $container->setParameter('container.dumper.inline_class_loader', \PHP_VERSION_ID <70400 || !ini_get('opcache.preload')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
isn't it an issue to change the cache-warmup behavior based on thepreload config, while you need to warmup your cache before being able to confire the preloading ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This will remove inline "require" statements that are generated currently.
They are not needed anymore when preloading is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
my issue is that runningcache:warmup then adding thepreload file in the php.ini and then runningcache:warmup again will produce a different cache.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yes ok, I wouldn't care much :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
OK, removed :)
nicolas-grekasDec 11, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ppl that care about the extra perf this would provide would better enable preloading instead on PHP 7.4.
Removing will prevent issues with CLI vs FPM with different config for opcache.preload.
…MicroKernelTrait::registerBundles()` and `getProjectDir()`
…entations for `MicroKernelTrait::registerBundles()` and `getProjectDir()` (nicolas-grekas)This PR was merged into the 5.1-dev branch.Discussion----------[FrameworkBundle] Added flex-compatible default implementations for `MicroKernelTrait::registerBundles()` and `getProjectDir()`| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -I think it's safe now to migrate some flex-based defaults from the recipe to the bundle.No BC break here as all existing kernels already redefine this method.Commits-------a689807 [FrameworkBundle] Added flex-compatible default implementations for `MicroKernelTrait::registerBundles()` and `getProjectDir()`
…in MicroKernelTrait::configureContainer() (nicolas-grekas)This PR was merged into the 5.1-dev branch.Discussion----------[FrameworkBundle] Allow using a ContainerConfigurator in MicroKernelTrait::configureContainer()| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -This PR is a continuation of#32937 (it reverts some parts of it that are not needed anymore). It builds on#34872 for now.This PR allows using the PHP-DSL natively in our `Kernel::configureContainer()` methods.It allows the same in our `Kernel::configureRoutes()` methods.Both signatures are handled gracefully with no deprecations to let existing code in peace:- `protected function configureContainer(ContainerBuilder $c, LoaderInterface $loader);`- `protected function configureContainer(ContainerConfigurator $c);` (a loader is always passed as 2nd arg to ease FC)Same for routes:- `protected function configureRoutes(RoutingConfigurator $routes);`- `protected function configureRoutes(RouteCollectionBuilder $routes);` (this one is deprecated because `RouteCollectionBuilder` is deprecated)Here is my working `src/Kernel.php` after this change:```phpclass Kernel extends BaseKernel{ use MicroKernelTrait; protected function configureContainer(ContainerConfigurator $container): void { $container->import('../config/{packages}/*.yaml'); $container->import('../config/{packages}/'.$this->environment.'/*.yaml'); $container->import('../config/services.yaml'); $container->import('../config/{services}_'.$this->environment.'.yaml'); } protected function configureRoutes(RoutingConfigurator $routes): void { $routes->import('../config/{routes}/'.$this->environment.'/*.yaml'); $routes->import('../config/{routes}/*.yaml'); $routes->import('../config/routes.yaml'); }}```Commits-------cf45eec [FrameworkBundle] Allow using a ContainerConfigurator in MicroKernelTrait::configureContainer()
… of controllers and service factories (nicolas-grekas)This PR was merged into the 5.1-dev branch.Discussion----------[FrameworkBundle] Allow using the kernel as a registry of controllers and service factories| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets |Fix#28992,fix#29997| License | MIT| Doc PR | -This PR builds on#34873 and#34872 and allows using the `Kernel` as a registry of autowired controllers and service factories. The `ContainerConfigurator` passed to `configureContainer()` defaults to declaring autowired and autoconfigured services.TL;DR: Silex is back but in a much more powerful way \o/Here is a Kernel that just works and displays `Hello App\Foo` on the `/` route:```phpclass Kernel extends BaseKernel{ use MicroKernelTrait; protected function configureContainer(ContainerConfigurator $container): void { $container->services() ->load('App\\', '../src') ->set(Foo::class) ->factory([$this, 'createFoo']); } public function createFoo(Bar $bar) { return new Foo($bar); } protected function configureRoutes(RoutingConfigurator $routes): void { $routes->add('home', '/')->controller([$this, 'helloAction']); } public function helloAction(Foo $foo) { return new Response('Hello '.get_class($foo)); }}```Commits-------9c9b99c [FrameworkBundle] Allow using the kernel as a registry of controllers and service factories
Uh oh!
There was an error while loading.Please reload this page.
I think it's safe now to migrate some flex-based defaults from the recipe to the bundle.
No BC break here as all existing kernels already redefine this method.