Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[FrameworkBundle][ContainerLintCommand] Style messages#34865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| $container->compile(); | ||
| try { | ||
| $container->compile(); | ||
| } catch (InvalidArgumentException $e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should we check if the exception was thrown in CheckTypeDeclarationsPass?
15187b1 to05428f2CompareI rebased on master as this is a new behavior. |
src/Symfony/Bundle/FrameworkBundle/Command/ContainerLintCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Bundle/FrameworkBundle/Command/ContainerLintCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
… when the kernel or the container is not supported (fancyweb)This PR was merged into the 4.4 branch.Discussion----------[FrameworkBundle][ContainerLintCommand] Improve messages when the kernel or the container is not supported| Q | A| ------------- | ---| Branch? | 4.4| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets |#34865 (comment)| License | MIT| Doc PR | -Minor wording suggested here#34865 (comment)Commits-------6986394 [FrameworkBundle][ContainerLintCommand] Improve messages when the kernel or the container is not supported
05428f2 tocb010e9CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
much appreciated :)
src/Symfony/Bundle/FrameworkBundle/Command/ContainerLintCommand.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
cb010e9 to93aa5bcCompare…positive feedback on stderr (fancyweb)This PR was merged into the 3.4 branch.Discussion----------[FrameworkBundle][TranslationUpdateCommand] Do not output positive feedback on stderr| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |#34865 (comment)| License | MIT| Doc PR | -Outputing everything on stderr seems wrong. I'm going to check upper branches.Commits-------87212e4 [FrameworkBundle][TranslationUpdateCommand] Do not output positive feedback on stderr
Thank you@fancyweb. |
… (fancyweb)This PR was merged into the 5.1-dev branch.Discussion----------[FrameworkBundle][ContainerLintCommand] Style messages| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -It gives a better feedback.Commits-------93aa5bc [FrameworkBundle][ContainerLintCommand] Style messages
Uh oh!
There was an error while loading.Please reload this page.
It gives a better feedback.