Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add support for safe HTTP preference - RFC 8674#34847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfrompyrech:safe-preference
Jan 10, 2020
Merged

Add support for safe HTTP preference - RFC 8674#34847

fabpot merged 1 commit intosymfony:masterfrompyrech:safe-preference
Jan 10, 2020

Conversation

pyrech
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

RFC 8674 (not a IETF standard at the moment) defines a way for user agents to ask for "safe" content to a server. This PR add helper methods to :

  • know if the user agent prefers a safe content
  • mark the response as safe

GregoireHebert, apfelbox, and rvanlaak reacted with thumbs up emojidamienalexandre reacted with hooray emoji
@nicolas-grekasnicolas-grekas added this to thenext milestoneDec 6, 2019
@cjunge
Copy link

Is a default value offalse the same as not specifying "safe"?

@pyrech
Copy link
ContributorAuthor

pyrech commentedDec 7, 2019•
edited
Loading

@cjunge I'm not sure to understand where this default value would be. Do you mean in the request or in the response?

Anyway, from what I understand from the RFC:

  • either the client requests for safe content if possible or it requests a normal response
  • either the server send a response with safe preference applied or it send a normal response.

There is no such thing as "prefering a not safe content" or sending a response with "preference not applied".

@pyrech
Copy link
ContributorAuthor

Comments fixed and PR rebased 😉

@nicolas-grekas
Copy link
Member

Oups, wait, tests fail.

@pyrech
Copy link
ContributorAuthor

Oups, sorry, tests should be green now

@fabpot
Copy link
Member

Thank you@pyrech.

fabpot added a commit that referenced this pull requestJan 10, 2020
This PR was merged into the 5.1-dev branch.Discussion----------Add support for safe HTTP preference - RFC 8674| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -[RFC 8674](https://tools.ietf.org/html/rfc8674) (not a IETF standard at the moment) defines a way for user agents to ask for "safe" content to a server. This PR add helper methods to :- know if the user agent prefers a safe content- mark the response as safeCommits-------7f2cef7 Add support for safe preference - RFC8674
@fabpotfabpot merged commit7f2cef7 intosymfony:masterJan 10, 2020
@pyrechpyrech deleted the safe-preference branchJanuary 13, 2020 08:01
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestFeb 17, 2020
This PR was merged into the master branch.Discussion----------Add documentation for RFC 8674 supportAdd documentation for the PRsymfony/symfony#34847Fix#12915Commits-------54d06f5 Add documentation for RFC 8674 support
@nicolas-grekasnicolas-grekas modified the milestones:next,5.1May 4, 2020
@fabpotfabpot mentioned this pull requestMay 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@fabpotfabpotfabpot approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

5 participants
@pyrech@cjunge@nicolas-grekas@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp