Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[3.4][Validator] Allow underscore character "_" in URL username and password#34832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
javiereguiluz left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In thehttps://tools.ietf.org/html/rfc1738 they don't say anything about not allowing this.
Thus, only alphanumerics and the special characters "$-_.+!*'()," maybe used unencoded within a URL.[...]Within the user and password field, any ":", "@", or "/" must be encoded.So, using_ looks like it's allowed in both the user and password.
Thanks Romain!
Thank you@romainneutron. |
…rname and password (romainneutron)This PR was merged into the 3.4 branch.Discussion----------[3.4][Validator] Allow underscore character "_" in URL username and password| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| Deprecations? | no| License | MITHello!It's been a long time since my last push on Symfony :)Here's a bug fix. I think URL usernames and password may contain an underscore. Let me know!Commits-------869518b [Validator] Allow underscore character "_" in URL username and password
Hello!
It's been a long time since my last push on Symfony :)
Here's a bug fix. I think URL usernames and password may contain an underscore. Let me know!