Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Yaml] support YAML 1.2 octal notation, deprecate YAML 1.1 one#34813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromxabbuh:issue-34807
May 5, 2020

Conversation

xabbuh
Copy link
Member

@xabbuhxabbuh commentedDec 4, 2019•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
Deprecations?yes
TicketsFix#34807
LicenseMIT
Doc PR

Copy link
Member

@stofstof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

should we also add support for parsing YAML 1.2 octal notation with0o ?

@trigger_error(sprintf('Support for parsing the invalid octal number %s is deprecated since Symfony 5.1.', $scalar), E_USER_DEPRECATED);
}

return '0' == $scalar[1] ? -octdec($octal) : (($raw === (string) $cast) ? $cast : $raw);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

should be a string comparison

cebe reacted with thumbs up emoji
@Nyholm
Copy link
Member

@xabbuh Friendly ping

@xabbuhxabbuhforce-pushed theissue-34807 branch 2 times, most recently fromd3dfffb to671f0caCompareMay 4, 2020 10:17
@xabbuhxabbuh changed the title[Yaml] deprecate parsing octal numbers with invalid formats[Yaml] support YAML 1.2 octal notation, deprecate YAML 1.1 oneMay 4, 2020
@xabbuhxabbuh modified the milestones:next,5.1May 4, 2020
@fabpot
Copy link
Member

Thank you@xabbuh.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@cebecebecebe left review comments

@stofstofstof left review comments

@fabpotfabpotfabpot approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

[YAML] Parsing octal numbers: unexpected value conversion and PHP 7.4 notice
6 participants
@xabbuh@Nyholm@fabpot@cebe@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp