NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Yaml] fix parsing negative octal numbers#34812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:3.4fromxabbuh:parse-negative-octal-numbers

Dec 7, 2019

Merged

[Yaml] fix parsing negative octal numbers#34812

fabpot merged 1 commit intosymfony:3.4fromxabbuh:parse-negative-octal-numbers

Dec 7, 2019

Conversation

Copy link

Member

xabbuh commentedDec 4, 2019

Q	A
Branch?	3.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets
License	MIT
Doc PR

fix parsing negative octal numbers

7ab53f9

xabbuh added this to the3.4 milestone

Dec 4, 2019

carsonbot added Status: Needs Review Yaml Bug labels

Dec 4, 2019

Copy link

MemberAuthor

xabbuh commentedDec 4, 2019

while working on#34807 I realised that we actually do not correctly parse negative octal numbers

Copy link

Member

stof commentedDec 4, 2019

Based onhttps://yaml.org/spec/1.2/spec.html#id2805071, I don't think negative octal actually make sense in YAML

Copy link

Member

OK, according tohttps://yaml.org/type/int.html, they do make sense in YAML 1.1 (and this octal without0o is the 1.1 octal syntax). I think we need to clarify which YAML spec we follow in the component (I think the current answer is "a mix of 1.1 and 1.2, being compliant with none of the 2 due to the mix")

Copy link

MemberAuthor

xabbuh commentedDec 4, 2019

In#34813 I am working on a deprecation. Looks like I need to improve that a bit so that in the future we will only support the0o prefix.

nicolas-grekas approved these changes

Dec 6, 2019

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Dec 6, 2019

fabpot approved these changes

Dec 7, 2019

View reviewed changes

Copy link

Member

fabpot commentedDec 7, 2019

Thank you@xabbuh.

fabpot added a commit that referenced this pull request

Dec 7, 2019

bug#34812[Yaml] fix parsing negative octal numbers (xabbuh)

8f2cd5b

This PR was merged into the 3.4 branch.Discussion----------[Yaml] fix parsing negative octal numbers| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       || License       | MIT| Doc PR        |Commits-------7ab53f9 fix parsing negative octal numbers

fabpot merged commit7ab53f9 intosymfony:3.4

Dec 7, 2019

xabbuh deleted the parse-negative-octal-numbers branch

December 7, 2019 14:03

This was referencedDec 19, 2019

Release v4.4.2#35053

Merged

Release v5.0.2#35055

Merged

This was referencedJan 21, 2020

Release v3.4.37#35411

Merged