Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[TwigBridge] Update bootstrap_4_layout.html.twig missing switch-custom label#34811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
bykclk commentedDec 4, 2019
I just tested this in a real project - I couldn't find bug. How to reproduce ? |
for a test case: in a FormType ->add('categories', EntityType::class, ['label' =>false,'required' =>false,'class' => Category::class,'expanded' =>true,'multiple' =>true,'label_attr' => ['class' =>'switch-custom'] ] ) before after |
bykclk left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice job there! I just tested this in a real project - no missing pieces - it works great :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(for 4.4)
Missing custom-control-label for custom-switch
Thank you@sabruss. |
…witch-custom label (sabruss)This PR was submitted for the master branch but it was merged into the 4.4 branch instead (closes#34811).Discussion----------[TwigBridge] Update bootstrap_4_layout.html.twig missing switch-custom label| Q | A| ------------- | ---| Branch? | 5.0| Bug fix? | yes| New feature? | no| License | MITMissing .custom-control-label for bootstrap custom-switch when using .switch-custom class in label_attrCommits-------9347b2e [TwigBridge] Update bootstrap_4_layout.html.twig
Missing .custom-control-label for bootstrap custom-switch when using .switch-custom class in label_attr